Enable LLD for POSIX LTO builds on Linux.

Enable LLD for POSIX LTO builds on Linux.

This is a stripped down version of (reverted)
change: https://codereview.chromium.org/2831213006/

That change was reverted because ThinLTO regresses the binary
size too much. LLD was a harmless part of the change,
so it's worth enabling it.

Based on https://codereview.chromium.org/2844883002/ by
krasin@chromium.org, who is no longer with Google.

BUG=607968
R=dpranke@chromium.org,thakis@chromium.org

Review-Url: https://codereview.chromium.org/2877913003
Cr-Commit-Position: refs/heads/master@{#471532}
Committed: https://chromium.googlesource.com/chromium/src/+/e6a66337552cfd9a9af9471775ad5b67ee588b88

[pcc1, 2017-05-12 21:24:31]

The CQ bit was checked by pcc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 21:25:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dirk Pranke, 2017-05-12 21:27:33]

lgtm

[Nico, 2017-05-12 21:36:34]

On 2017/05/12 21:27:33, Dirk Pranke (slow) wrote:
> lgtm

Lgtm; it'd be cool to do this for regular builds too sometime soon.

Once this change has stuck, we can get rid of the llvm gold .so, right?

[pcc1, 2017-05-12 21:52:10]

On 2017/05/12 21:36:34, Nico wrote:
> On 2017/05/12 21:27:33, Dirk Pranke (slow) wrote:
> > lgtm
> 
> Lgtm; it'd be cool to do this for regular builds too sometime soon.

Yes, we should check whether crbug.com/706429 is still an issue first though.

> Once this change has stuck, we can get rid of the llvm gold .so, right?

I think so. My only concern would be ChromeOS, but I gather from the reviews
linked from crbug.com/707803 that they use their own copy of the gold plugin, so
I think it wouldn't be affected. I'll ask someone on ChromeOS to make sure
though.

[commit-bot: I haz the power, 2017-05-12 23:47:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 23:47:31]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[pcc1, 2017-05-13 00:00:05]

The CQ bit was checked by pcc@chromium.org

[commit-bot: I haz the power, 2017-05-13 00:01:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-13 01:26:55]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494633605611920, "parent_rev":
"1585fc7d5b1d7bed346e1dd0eaa37094918f9289", "commit_rev":
"e6a66337552cfd9a9af9471775ad5b67ee588b88"}

[commit-bot: I haz the power, 2017-05-13 01:27:04]

Description was changed from

==========
Enable LLD for POSIX LTO builds on Linux.

This is a stripped down version of (reverted)
change: https://codereview.chromium.org/2831213006/

That change was reverted because ThinLTO regresses the binary
size too much. LLD was a harmless part of the change,
so it's worth enabling it.

Based on https://codereview.chromium.org/2844883002/ by
krasin@chromium.org, who is no longer with Google.

BUG=607968
R=dpranke@chromium.org,thakis@chromium.org
==========

to

==========
Enable LLD for POSIX LTO builds on Linux.

This is a stripped down version of (reverted)
change: https://codereview.chromium.org/2831213006/

That change was reverted because ThinLTO regresses the binary
size too much. LLD was a harmless part of the change,
so it's worth enabling it.

Based on https://codereview.chromium.org/2844883002/ by
krasin@chromium.org, who is no longer with Google.

BUG=607968
R=dpranke@chromium.org,thakis@chromium.org

Review-Url: https://codereview.chromium.org/2877913003
Cr-Commit-Position: refs/heads/master@{#471532}
Committed:
https://chromium.googlesource.com/chromium/src/+/e6a66337552cfd9a9af9471775ad...
==========

[commit-bot: I haz the power, 2017-05-13 01:27:05]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e6a66337552cfd9a9af9471775ad...

[pcc1, 2017-05-22 21:31:42]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2900883002/ by pcc@chromium.org.

The reason for reverting is: Breaks crash reporting.

BUG=716484.

[Dirk Pranke, 2017-05-22 21:32:04]

lgtm