Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: src/objects/break-points-info.h

Issue 2900713004: [objects] Extract DebugInfo and BreakPointInfo to own file (Closed)
Patch Set: Rename Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/objects/break-points-info.h
diff --git a/src/objects/break-points-info.h b/src/objects/break-points-info.h
new file mode 100644
index 0000000000000000000000000000000000000000..34371ec6f668d09364241bc6f45ae04080307ded
--- /dev/null
+++ b/src/objects/break-points-info.h
@@ -0,0 +1,54 @@
+// Copyright 2017 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef V8_OBJECTS_BREAK_POINTS_INFO_H_
+#define V8_OBJECTS_BREAK_POINTS_INFO_H_
+
+#include "src/objects.h"
+
+// Has to be the last include (doesn't have include guards):
+#include "src/objects/object-macros.h"
+
+namespace v8 {
+namespace internal {
+
+// The BreakPointInfo class holds information for break points set in a
+// function. The DebugInfo object holds a BreakPointInfo object for each code
+// position with one or more break points.
+class BreakPointInfo : public Tuple2 {
marja 2017/05/22 13:37:39 This file should be called break-point-info, since
jgruber 2017/05/22 13:48:26 Ugh, my comment got lost since I uploaded new patc
+ public:
+ // The position in the source for the break position.
+ DECL_INT_ACCESSORS(source_position)
+ // List of related JavaScript break points.
+ DECL_ACCESSORS(break_point_objects, Object)
+
+ // Removes a break point.
+ static void ClearBreakPoint(Handle<BreakPointInfo> info,
+ Handle<Object> break_point_object);
+ // Set a break point.
+ static void SetBreakPoint(Handle<BreakPointInfo> info,
+ Handle<Object> break_point_object);
+ // Check if break point info has this break point object.
+ static bool HasBreakPointObject(Handle<BreakPointInfo> info,
+ Handle<Object> break_point_object);
+ // Get the number of break points for this code offset.
+ int GetBreakPointCount();
+
+ int GetStatementPosition(Handle<DebugInfo> debug_info);
+
+ DECLARE_CAST(BreakPointInfo)
+
+ static const int kSourcePositionIndex = kValue1Offset;
+ static const int kBreakPointObjectsIndex = kValue2Offset;
+
+ private:
+ DISALLOW_IMPLICIT_CONSTRUCTORS(BreakPointInfo);
+};
+
+#include "src/objects/object-macros-undef.h"
marja 2017/05/22 13:37:39 This should be after the namespace closing
jgruber 2017/05/22 13:48:26 Will do.
+
+} // namespace internal
+} // namespace v8
+
+#endif // V8_OBJECTS_BREAK_POINTS_INFO_H_

Powered by Google App Engine
This is Rietveld 408576698