components/password_manager/content/browser/credential_manager_impl.h - Issue 2900693002: [Password Manager] Convert |pending_login_managers_| to an array of scoped_refptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/browser/credential_manager_impl.h

Issue 2900693002: [Password Manager] Convert |pending_login_managers_| to an array of scoped_refptr (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/passwords_client_ui_delegate.h ('k') | components/password_manager/content/browser/credential_manager_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/browser/credential_manager_impl.h

diff --git a/components/password_manager/content/browser/credential_manager_impl.h b/components/password_manager/content/browser/credential_manager_impl.h

index 6db0b992f106151e058e8106c7c3c1cd073f78a0..dd8acbe2f3bfcc8770979e925bb6d2de6e946068 100644

--- a/components/password_manager/content/browser/credential_manager_impl.h

+++ b/components/password_manager/content/browser/credential_manager_impl.h

@@ -9,6 +9,7 @@

#include "base/callback.h"

#include "base/macros.h"

+#include "base/memory/ref_counted.h"

#include "base/memory/weak_ptr.h"

#include "components/password_manager/content/common/credential_manager.mojom.h"

#include "components/password_manager/core/browser/credential_manager_password_form_manager.h"

@@ -84,7 +85,7 @@ class CredentialManagerImpl

virtual base::WeakPtr<PasswordManagerDriver> GetDriver();

PasswordManagerClient* client_;

- std::unique_ptr<CredentialManagerPasswordFormManager> form_manager_;

+ scoped_refptr<CredentialManagerPasswordFormManager> form_manager_;

// Set to false to disable automatic signing in.

BooleanPrefMember auto_signin_enabled_;