components/password_manager/content/browser/credential_manager_impl.cc - Issue 2900693002: [Password Manager] Convert |pending_login_managers_| to an array of scoped_refptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/browser/credential_manager_impl.cc

Issue 2900693002: [Password Manager] Convert |pending_login_managers_| to an array of scoped_refptr (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/content/browser/credential_manager_impl.h ('k') | components/password_manager/content/browser/credential_manager_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/browser/credential_manager_impl.cc

diff --git a/components/password_manager/content/browser/credential_manager_impl.cc b/components/password_manager/content/browser/credential_manager_impl.cc

index 608ccbb578683e5f3e4498784ea684e7ce1f02e3..9d903e7f123ff350f4d0667dfe1818f6d60c83dc 100644

--- a/components/password_manager/content/browser/credential_manager_impl.cc

+++ b/components/password_manager/content/browser/credential_manager_impl.cc

@@ -83,7 +83,7 @@ void CredentialManagerImpl::Store(const CredentialInfo& credential,

// is only available on HTTPS origins.

auto form_fetcher = base::MakeUnique<FormFetcherImpl>(

PasswordStore::FormDigest(*observed_form), client_, false, false);

- form_manager_ = base::MakeUnique<CredentialManagerPasswordFormManager>(

+ form_manager_ = base::MakeRefCounted<CredentialManagerPasswordFormManager>(

client_, GetDriver(), *observed_form, std::move(form), this, nullptr,

std::move(form_fetcher));

}