Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: chrome/browser/ui/passwords/passwords_client_ui_delegate.h

Issue 2900693002: [Password Manager] Convert |pending_login_managers_| to an array of scoped_refptr (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/passwords_client_ui_delegate.h
diff --git a/chrome/browser/ui/passwords/passwords_client_ui_delegate.h b/chrome/browser/ui/passwords/passwords_client_ui_delegate.h
index b2b5928a8c88f272fe721ce341004f897a2e9963..217424914face454e198cde07fac526239145ee9 100644
--- a/chrome/browser/ui/passwords/passwords_client_ui_delegate.h
+++ b/chrome/browser/ui/passwords/passwords_client_ui_delegate.h
@@ -10,6 +10,7 @@
#include <vector>
#include "base/callback.h"
+#include "base/memory/ref_counted.h"
#include "base/strings/string16.h"
#include "components/autofill/core/common/password_form.h"
@@ -30,13 +31,13 @@ class PasswordsClientUIDelegate {
// This stores the provided object and triggers the UI to prompt the user
// about whether they would like to save the password.
virtual void OnPasswordSubmitted(
- std::unique_ptr<password_manager::PasswordFormManager> form_manager) = 0;
+ scoped_refptr<password_manager::PasswordFormManager> form_manager) = 0;
// Called when the user submits a new password for an existing credential.
// This stores the provided object and triggers the UI to prompt the user
// about whether they would like to update the password.
virtual void OnUpdatePasswordSubmitted(
- std::unique_ptr<password_manager::PasswordFormManager> form_manager) = 0;
+ scoped_refptr<password_manager::PasswordFormManager> form_manager) = 0;
// Called when the site asks user to choose from credentials. This triggers
// the UI to prompt the user. |local_credentials| shouldn't be empty. |origin|
@@ -61,7 +62,7 @@ class PasswordsClientUIDelegate {
// Called when the password will be saved automatically, but we still wish to
// visually inform the user that the save has occured.
virtual void OnAutomaticPasswordSave(
- std::unique_ptr<password_manager::PasswordFormManager> form_manager) = 0;
+ scoped_refptr<password_manager::PasswordFormManager> form_manager) = 0;
// Called when a form is autofilled with login information, so we can manage
// password credentials for the current site which are stored in

Powered by Google App Engine
This is Rietveld 408576698