Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2900663002: arm: Fix to pass typed pointer with a cast to %p (Closed)

Created:
3 years, 7 months ago by honggyu.kim
Modified:
3 years, 7 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

arm: Fix to pass typed pointer with a cast to %p This patch fixes the below compilation error with a static_cast. ../src/arm/disasm-arm.cc:689:72: error: format specifies type 'void *' but the argument has type 'v8::internal::byte *' (aka 'unsigned char *') [-Werror,-Wformat-pedantic] out_buffer_pos_ += SNPrintF(out_buffer_ + out_buffer_pos_, "%p", addr); R=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2900663002 Cr-Commit-Position: refs/heads/master@{#45457} Committed: https://chromium.googlesource.com/v8/v8/+/22db799a92919060338745037495aebbc62611bc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/arm/disasm-arm.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
honggyu.kim
Hi, please take a look at it!
3 years, 7 months ago (2017-05-22 07:56:41 UTC) #1
Yang
lgtm
3 years, 7 months ago (2017-05-22 11:29:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2900663002/1
3 years, 7 months ago (2017-05-22 12:05:09 UTC) #4
honggyu.kim
On 2017/05/22 11:29:03, Yang wrote: > lgtm Thanks for your quick review!
3 years, 7 months ago (2017-05-22 12:10:12 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 12:39:01 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/22db799a92919060338745037495aebbc62...

Powered by Google App Engine
This is Rietveld 408576698