Treat selection as focused if it contains focused element

Treat selection as focused if it contains focused element

BUG=724925
TEST=FrameSelectionTest.RangeContainsFocus

Review-Url: https://codereview.chromium.org/2900553005
Cr-Commit-Position: refs/heads/master@{#473814}
Committed: https://chromium.googlesource.com/chromium/src/+/f15f52293342a5d3dfa6fd3be727b2058711c2d3

[Xiaocheng, 2017-05-22 18:49:27]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 18:50:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 20:56:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 20:56:32]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2017-05-23 01:03:25]

Description was changed from

==========
Treat selection as focused if it contains focused element

BUG=724925
==========

to

==========
Treat selection as focused if it contains focused element

BUG=724925
TEST=FrameSelectionTest.RangeContainsFocus
==========

[Xiaocheng, 2017-05-23 01:03:33]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2017-05-23 01:03:33]

PTAL.

[yosin_UTC9, 2017-05-23 01:15:50]

lgtm w/ nit

https://codereview.chromium.org/2900553005/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/FrameSelection.cpp (right):

https://codereview.chromium.org/2900553005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/FrameSelection.cpp:447: const
PositionInFlatTree focused_position(focused_element, 0);
It is better to use PositionInFlatTree::FirstPositionInNode(focused_element)?

Because, we want to deprecated Node/offset ctor:

  // For creating offset positions:
  // FIXME: This constructor should eventually go away. See bug 63040.
  PositionTemplate(Node* anchor_node, int offset);


https://bugs.webkit.org/show_bug.cgi?id=63040
[meta] positionIsOffsetInAnchor should only accept text nodes

[Xiaocheng, 2017-05-23 01:57:00]

The CQ bit was checked by xiaochengh@chromium.org

[Xiaocheng, 2017-05-23 01:57:01]

Fixed and thanks for reviewing!

[Xiaocheng, 2017-05-23 01:57:01]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2900553005/#ps20001
(title: "Mon May 22 18:52:27 PDT 2017")

[commit-bot: I haz the power, 2017-05-23 01:57:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 05:11:23]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495504620916140,
"parent_rev": "e4d990302ab30a05aada8e4928e3ec19a02222a7", "commit_rev":
"f15f52293342a5d3dfa6fd3be727b2058711c2d3"}

[commit-bot: I haz the power, 2017-05-23 05:11:33]

Description was changed from

==========
Treat selection as focused if it contains focused element

BUG=724925
TEST=FrameSelectionTest.RangeContainsFocus
==========

to

==========
Treat selection as focused if it contains focused element

BUG=724925
TEST=FrameSelectionTest.RangeContainsFocus

Review-Url: https://codereview.chromium.org/2900553005
Cr-Commit-Position: refs/heads/master@{#473814}
Committed:
https://chromium.googlesource.com/chromium/src/+/f15f52293342a5d3dfa6fd3be727...
==========

[commit-bot: I haz the power, 2017-05-23 05:11:34]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f15f52293342a5d3dfa6fd3be727...