third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp - Issue 2900553005: Treat selection as focused if it contains focused element

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp

Issue 2900553005: Treat selection as focused if it contains focused element (Closed)

Patch Set: Mon May 22 18:52:27 PDT 2017 Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp b/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp

index 76d0f6d8cd54a03ebf0e37edde875111ac69cf04..0cc7e19026e8252cc2cb129812c511c1d36c8652 100644

--- a/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp

+++ b/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp

@@ -883,7 +883,7 @@ TEST_F(FrameSelectionTest, RangeContainsFocus) {

Element* const alink = GetDocument().getElementById("alink");

alink->focus();

EXPECT_TRUE(Selection().GetSelectionInDOMTree().IsRange());

- EXPECT_FALSE(Selection().SelectionHasFocus());

+ EXPECT_TRUE(Selection().SelectionHasFocus());

EXPECT_FALSE(Selection().IsHidden()); // Range still visible.

}