Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2900303002: Reland "Enforce constant size and device scale factor for surfaces" with fixes (Closed)

Created:
3 years, 7 months ago by Saman Sami
Modified:
3 years, 7 months ago
Reviewers:
Fady Samuel, sadrul, boliu, piman
CC:
chromium-reviews, sadrul, mlamouri+watch-content_chromium.org, James Su, creis+watch_chromium.org, yusukes+watch_chromium.org, nona+watch_chromium.org, shuchen+watch_chromium.org, nasko+codewatch_chromium.org, jam, xjz+watch_chromium.org, jbauman+watch_chromium.org, danakj+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, cc-bugs_chromium.org, mfoltz+watch_chromium.org, android-webview-reviews_chromium.org, miu+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland "Enforce constant size and device scale factor for surfaces" with fixes The original CL(crrev.com/2848223003) surfaced two problems that this CL fixes: - SurfaceAggregatorPerfTest sends frames with zero size and device scale factor - SurfacesInstance does not properly allocate new LocalSurfaceIds. TBR=piman@chromium.org,boliu@chromium.org,sadrul@chromium.org BUG=725838, 725840 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2900303002 Cr-Commit-Position: refs/heads/master@{#474357} Committed: https://chromium.googlesource.com/chromium/src/+/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046

Patch Set 1 #

Patch Set 2 : Set output rect #

Patch Set 3 : Fixed webview #

Unified diffs Side-by-side diffs Delta from patch set Stats (+255 lines, -170 lines) Patch
M android_webview/browser/hardware_renderer.h View 1 chunk +2 lines, -1 line 0 comments Download
M android_webview/browser/hardware_renderer.cc View 4 chunks +14 lines, -8 lines 0 comments Download
M android_webview/browser/surfaces_instance.cc View 1 2 2 chunks +8 lines, -4 lines 0 comments Download
M android_webview/browser/test/rendering_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/surfaces/compositor_frame_sink_support.h View 3 chunks +3 lines, -4 lines 0 comments Download
M cc/surfaces/compositor_frame_sink_support.cc View 4 chunks +28 lines, -7 lines 0 comments Download
M cc/surfaces/compositor_frame_sink_support_unittest.cc View 3 chunks +0 lines, -6 lines 0 comments Download
M cc/surfaces/direct_compositor_frame_sink.h View 1 chunk +2 lines, -1 line 0 comments Download
M cc/surfaces/direct_compositor_frame_sink.cc View 1 chunk +8 lines, -6 lines 0 comments Download
M cc/surfaces/direct_compositor_frame_sink_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M cc/surfaces/display_unittest.cc View 10 chunks +16 lines, -5 lines 0 comments Download
M cc/surfaces/surface.h View 3 chunks +6 lines, -5 lines 0 comments Download
M cc/surfaces/surface.cc View 5 chunks +18 lines, -6 lines 0 comments Download
M cc/surfaces/surface_aggregator_perftest.cc View 1 5 chunks +8 lines, -10 lines 0 comments Download
M cc/surfaces/surface_aggregator_unittest.cc View 6 chunks +3 lines, -12 lines 0 comments Download
M cc/surfaces/surface_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/surfaces/surface_manager.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M cc/surfaces/surface_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M cc/test/compositor_frame_helpers.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/test/test_compositor_frame_sink.h View 1 chunk +3 lines, -1 line 0 comments Download
M cc/test/test_compositor_frame_sink.cc View 1 chunk +12 lines, -9 lines 0 comments Download
M components/viz/frame_sinks/gpu_compositor_frame_sink.cc View 1 chunk +4 lines, -1 line 0 comments Download
M components/viz/frame_sinks/gpu_root_compositor_frame_sink.cc View 1 chunk +4 lines, -1 line 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/delegated_frame_host.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 35 chunks +45 lines, -40 lines 0 comments Download
M content/renderer/android/synchronous_compositor_frame_sink.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/android/synchronous_compositor_frame_sink.cc View 4 chunks +25 lines, -12 lines 0 comments Download
M ui/android/delegated_frame_host_android.cc View 1 chunk +4 lines, -1 line 0 comments Download
M ui/aura/local/compositor_frame_sink_local.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/aura/local/compositor_frame_sink_local.cc View 1 chunk +11 lines, -10 lines 0 comments Download

Messages

Total messages: 30 (27 generated)
Fady Samuel
lgtm
3 years, 7 months ago (2017-05-24 18:06:33 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2900303002/40001
3 years, 7 months ago (2017-05-24 18:08:02 UTC) #27
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 18:14:48 UTC) #30
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/cf887b6f97e0762a83e1e054a9d4...

Powered by Google App Engine
This is Rietveld 408576698