Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2900163003: Remove NotImplemented from IsInVR (Closed)

Created:
3 years, 7 months ago by asimjour1
Modified:
3 years, 7 months ago
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Remove NotImplemented from IsInVR If a platform does not support VR, IsInVR should return false without spamming the console. BUG=712306 Review-Url: https://codereview.chromium.org/2822223002 Cr-Original-Commit-Position: refs/heads/master@{#465599} Review-Url: https://codereview.chromium.org/2900163003 . Cr-Commit-Position: refs/branch-heads/3071@{#685} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/cf2b7470eef6f2af442b63a8e6739e916212b8e3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M content/browser/renderer_host/render_widget_host_view_base.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
asimjour1
Committed patchset #1 (id:1) manually as cf2b7470eef6f2af442b63a8e6739e916212b8e3.
3 years, 7 months ago (2017-05-24 16:58:36 UTC) #2
asimjour
PTAL
3 years, 7 months ago (2017-05-24 17:01:45 UTC) #4
Avi (use Gerrit)
3 years, 7 months ago (2017-05-24 18:06:49 UTC) #5
Message was sent while issue was closed.
Yep! Thank you. LGTM

Powered by Google App Engine
This is Rietveld 408576698