Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2822223002: Remove NotImplemented from IsInVR (Closed)

Created:
3 years, 8 months ago by asimjour1
Modified:
3 years, 8 months ago
Reviewers:
Charlie Reis, amp
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, James Su
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove NotImplemented from IsInVR If a platform does not support VR, IsInVR should return false without spamming the console. BUG=712306 Review-Url: https://codereview.chromium.org/2822223002 Cr-Commit-Position: refs/heads/master@{#465599} Committed: https://chromium.googlesource.com/chromium/src/+/37db26e938b37edc885a50ab1aca3aee1cfefb0d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M content/browser/renderer_host/render_widget_host_view_base.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
asimjour1
PTAL
3 years, 8 months ago (2017-04-18 16:14:55 UTC) #2
amp
lgtm
3 years, 8 months ago (2017-04-18 16:41:32 UTC) #3
Charlie Reis
LGTM
3 years, 8 months ago (2017-04-18 23:39:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2822223002/1
3 years, 8 months ago (2017-04-19 13:42:21 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 14:37:15 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/37db26e938b37edc885a50ab1aca...

Powered by Google App Engine
This is Rietveld 408576698