Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(938)

Issue 2900143004: Revert of Check missing headers in the build on CQ (Closed)

Created:
3 years, 7 months ago by vitaliii
Modified:
3 years, 7 months ago
Reviewers:
Dirk Pranke, Nico, wychen
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Check missing headers in the build on CQ (patchset #8 id:160001 of https://codereview.chromium.org/2628543003/ ) Reason for revert: This CL likely breaks |check_gn_headers| step. See crbug.com/725877 for details. Original issue's description: > Check missing headers in the build on CQ > > This script is run on the following bots on CQ: > - linux_chromium_dbg_ng > - linux_chromium_rel_ng > > Note that this script can only be added to bots that have "all" > in "additional_compile_targets". > > BUG=661774 > > Review-Url: https://codereview.chromium.org/2628543003 > Cr-Commit-Position: refs/heads/master@{#474218} > Committed: https://chromium.googlesource.com/chromium/src/+/ded5e27012a9b0d50de4b80a16e024fe5106b160 TBR=dpranke@chromium.org,thakis@chromium.org,wychen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=661774, 725877 Review-Url: https://codereview.chromium.org/2900143004 Cr-Commit-Position: refs/heads/master@{#474256} Committed: https://chromium.googlesource.com/chromium/src/+/5eba554ee38b7a6f78f54f1826fbd279f948c982

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -442 lines) Patch
M build/check_gn_headers.py View 1 chunk +1 line, -2 lines 0 comments Download
D build/check_gn_headers_whitelist.txt View 1 chunk +0 lines, -386 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 2 chunks +0 lines, -8 lines 0 comments Download
D testing/scripts/check_gn_headers.py View 1 chunk +0 lines, -46 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
vitaliii
Created Revert of Check missing headers in the build on CQ
3 years, 7 months ago (2017-05-24 12:02:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2900143004/1
3 years, 7 months ago (2017-05-24 12:03:41 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/5eba554ee38b7a6f78f54f1826fbd279f948c982
3 years, 7 months ago (2017-05-24 12:04:20 UTC) #7
Dirk Pranke
3 years, 7 months ago (2017-05-24 16:29:47 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698