Check missing headers in the build on CQ

Check missing headers in the build on CQ

This script is run on the following bots on CQ:
- linux_chromium_dbg_ng
- linux_chromium_rel_ng

Note that this script can only be added to bots that have "all"
in "additional_compile_targets".

BUG=661774
Review-Url: https://codereview.chromium.org/2628543003
Cr-Commit-Position: refs/heads/master@{#474218}
Committed: https://chromium.googlesource.com/chromium/src/+/ded5e27012a9b0d50de4b80a16e024fe5106b160

[wychen, 2017-01-10 12:22:23]

Description was changed from

==========
Check missing headers in GN on CQ

BUG=
==========

to

==========
Check missing headers in GN on CQ

This script is run on the following bots on CQ:
- linux_chromium_dbg_ng
- linux_chromium_rel_ng
- linux_android_dbg_ng
- linux_android_rel_ng

BUG=
==========

[wychen, 2017-01-10 15:34:30]

Patchset #1 (id:1) has been deleted

[wychen, 2017-01-10 17:24:03]

Description was changed from

==========
Check missing headers in GN on CQ

This script is run on the following bots on CQ:
- linux_chromium_dbg_ng
- linux_chromium_rel_ng
- linux_android_dbg_ng
- linux_android_rel_ng

BUG=
==========

to

==========
Check missing headers in GN on CQ

This script is run on the following bots on CQ:
- linux_chromium_dbg_ng
- linux_chromium_rel_ng
- linux_android_dbg_ng
- linux_android_rel_ng

BUG=661774
==========

[wychen, 2017-05-19 16:15:32]

Description was changed from

==========
Check missing headers in GN on CQ

This script is run on the following bots on CQ:
- linux_chromium_dbg_ng
- linux_chromium_rel_ng
- linux_android_dbg_ng
- linux_android_rel_ng

BUG=661774
==========

to

==========
Check missing headers in the build on CQ

This script is run on the following bots on CQ:
- linux_chromium_dbg_ng
- linux_chromium_rel_ng

Note that this script can only be added to bots that have "all"
in "additional_compile_targets".

BUG=661774
==========

[wychen, 2017-05-19 16:20:22]

wychen@chromium.org changed reviewers:
+ dpranke@chromium.org, thakis@chromium.org

[wychen, 2017-05-19 16:20:23]

PTAL.

After the optimization in https://codereview.chromium.org/2846473002 , the time
spent in this step is much shorter, and I think it's time to reconsider adding
this on CQ.

From
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...

check_gn_headers (with patch) ( 27 secs )
checkdeps (with patch) ( 2 mins, 2 secs )
checkperms (with patch) ( 35 secs )
nacl_integration (with patch) ( 56 secs )

From
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...

check_gn_headers (with patch) ( 17 secs )
nacl_integration (with patch) ( 58 secs )

If we compare the cost effectiveness of these scripts, check_gn_headers should
be worth it.

[Nico, 2017-05-19 19:20:38]

I'll leave this to Dirk.

https://codereview.chromium.org/2628543003/diff/80001/testing/scripts/check_g...
File testing/scripts/check_gn_headers.py (right):

https://codereview.chromium.org/2628543003/diff/80001/testing/scripts/check_g...
testing/scripts/check_gn_headers.py:22: os.path.join(common.SRC_DIR, 'build',
'gn_missing_headers.txt'),
either put this in build/check_gn_headers_whitelist.txt or in
testing/scripts/check_gn_headers_whitelist.py

[wychen, 2017-05-22 21:17:15]

https://codereview.chromium.org/2628543003/diff/80001/testing/scripts/check_g...
File testing/scripts/check_gn_headers.py (right):

https://codereview.chromium.org/2628543003/diff/80001/testing/scripts/check_g...
testing/scripts/check_gn_headers.py:22: os.path.join(common.SRC_DIR, 'build',
'gn_missing_headers.txt'),
On 2017/05/19 19:20:38, Nico wrote:
> either put this in build/check_gn_headers_whitelist.txt or in
> testing/scripts/check_gn_headers_whitelist.py

Done.

[Dirk Pranke, 2017-05-23 20:40:33]

lgtm

[wychen, 2017-05-23 23:11:45]

The CQ bit was checked by wychen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 23:13:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wychen, 2017-05-24 04:51:38]

The CQ bit was checked by wychen@chromium.org

[wychen, 2017-05-24 04:51:39]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2628543003/#ps160001
(title: "rebase and fixup")

[commit-bot: I haz the power, 2017-05-24 04:52:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 05:56:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 05:56:47]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[wychen, 2017-05-24 06:54:08]

The CQ bit was checked by wychen@chromium.org

[commit-bot: I haz the power, 2017-05-24 06:54:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 07:41:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 07:41:54]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[wychen, 2017-05-24 07:53:51]

The CQ bit was checked by wychen@chromium.org

[commit-bot: I haz the power, 2017-05-24 07:54:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 08:57:15]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1495612431281230,
"parent_rev": "7b451a789df9be84623fc114a4efe00f5e9dbb5e", "commit_rev":
"ded5e27012a9b0d50de4b80a16e024fe5106b160"}

[commit-bot: I haz the power, 2017-05-24 08:57:25]

Description was changed from

==========
Check missing headers in the build on CQ

This script is run on the following bots on CQ:
- linux_chromium_dbg_ng
- linux_chromium_rel_ng

Note that this script can only be added to bots that have "all"
in "additional_compile_targets".

BUG=661774
==========

to

==========
Check missing headers in the build on CQ

This script is run on the following bots on CQ:
- linux_chromium_dbg_ng
- linux_chromium_rel_ng

Note that this script can only be added to bots that have "all"
in "additional_compile_targets".

BUG=661774

Review-Url: https://codereview.chromium.org/2628543003
Cr-Commit-Position: refs/heads/master@{#474218}
Committed:
https://chromium.googlesource.com/chromium/src/+/ded5e27012a9b0d50de4b80a16e0...
==========

[commit-bot: I haz the power, 2017-05-24 08:57:27]

Committed patchset #8 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/ded5e27012a9b0d50de4b80a16e0...

[vitaliii, 2017-05-24 12:02:43]

A revert of this CL (patchset #8 id:160001) has been created in
https://codereview.chromium.org/2900143004/ by vitaliii@chromium.org.

The reason for reverting is: This CL likely breaks |check_gn_headers| step. See
crbug.com/725877 for details..

[wychen, 2017-05-24 18:59:34]

Patchset #9 (id:180001) has been deleted