Remove shm versions of immediate commands from command buffer

Remove shm versions of immediate commands from command buffer

The actual code uses only immediate commands. The shm versions are
either unused or used only by the unit tests.

Make the unit tests use the immediate commands.

Solves the problem of not having to implement one useless function for
the a new command when using immediate commands.

BUG=373763
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272991

[Kimmo Kinnunen, 2014-05-15 13:09:02]

This kind of came up with path rendering review. Would it be acceptable?

Also mentioned in (subsection "3 types of commands"):
http://dev.chromium.org/developers/design-documents/gpu-command-buffer


For consistency, bucket versions are fixed in:
https://codereview.chromium.org/282253002

[vmiura, 2014-05-15 17:55:16]

Seems OK to me.  Can we auto gen Immediate form tests, and/or include invalid
args tets?

piman@ jbauman@ do you foresee any need to keep shared memory versions of these
APIs?

[piman, 2014-05-15 19:45:43]

On 2014/05/15 17:55:16, vmiura wrote:
> Seems OK to me.  Can we auto gen Immediate form tests, and/or include invalid
> args tets?
> 
> piman@ jbauman@ do you foresee any need to keep shared memory versions of
these
> APIs?

No, this is good stuff.

[Kimmo Kinnunen, 2014-05-16 05:36:23]

On 2014/05/15 17:55:16, vmiura wrote:
> Seems OK to me.  Can we auto gen Immediate form tests, and/or include invalid
> args tets?

The intention was to not remove any tests. The intended removed ones are the
ones which test invalid shm ids. Those error conditions are not present in the
immediate variants.

I can add some tests or generation code if it's missing.

[vmiura, 2014-05-21 05:02:29]

On 2014/05/16 05:36:23, kkinnunen wrote:
> On 2014/05/15 17:55:16, vmiura wrote:
> > Seems OK to me.  Can we auto gen Immediate form tests, and/or include
invalid
> > args tets?
> 
> The intention was to not remove any tests. The intended removed ones are the
> ones which test invalid shm ids. Those error conditions are not present in the
> immediate variants.
> 
> I can add some tests or generation code if it's missing.

My mistake I see that they are there for immediate variants.  LGTM.

[Kimmo Kinnunen, 2014-05-26 08:52:27]

The CQ bit was checked by kkinnunen@nvidia.com

[commit-bot: I haz the power, 2014-05-26 08:53:06]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kkinnunen@nvidia.com/289993002/20001

[commit-bot: I haz the power, 2014-05-26 09:21:30]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/9077)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/12162)

[commit-bot: I haz the power, 2014-05-26 09:25:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-26 09:25:11]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)

[Kimmo Kinnunen, 2014-05-27 06:21:44]

The CQ bit was checked by kkinnunen@nvidia.com

[commit-bot: I haz the power, 2014-05-27 06:22:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kkinnunen@nvidia.com/289993002/40001

[commit-bot: I haz the power, 2014-05-27 08:09:47]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-05-27 08:13:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-27 08:13:46]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)

[Kimmo Kinnunen, 2014-05-27 13:01:05]

The CQ bit was checked by kkinnunen@nvidia.com

[commit-bot: I haz the power, 2014-05-27 13:01:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kkinnunen@nvidia.com/289993002/50001

[commit-bot: I haz the power, 2014-05-27 16:23:41]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)

[commit-bot: I haz the power, 2014-05-27 17:15:18]

Change committed as 272991