| Index: gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc
|
| diff --git a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc
|
| index a0a562495ca44b041613fdac44e297bb639e8e84..5e6a0d4e009869efd7c0aef5bb82394af2247b7c 100644
|
| --- a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc
|
| +++ b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc
|
| @@ -1204,13 +1204,13 @@ TEST_P(GLES2DecoderManualInitTest, NoDefaultTexParameterfv) {
|
| EXPECT_EQ(error::kNoError, ExecuteCmd(cmd1));
|
| EXPECT_EQ(GL_NO_ERROR, GetGLError());
|
|
|
| - TexParameterfv cmd2;
|
| + GLfloat data = GL_NEAREST;
|
| + TexParameterfvImmediate& cmd2 =
|
| + *GetImmediateAs<TexParameterfvImmediate>();
|
| cmd2.Init(GL_TEXTURE_2D,
|
| GL_TEXTURE_MAG_FILTER,
|
| - shared_memory_id_,
|
| - shared_memory_offset_);
|
| - GetSharedMemoryAs<GLfloat*>()[0] = GL_NEAREST;
|
| - EXPECT_EQ(error::kNoError, ExecuteCmd(cmd2));
|
| + &data);
|
| + EXPECT_EQ(error::kNoError, ExecuteImmediateCmd(cmd2, sizeof(data)));
|
| EXPECT_EQ(GL_INVALID_VALUE, GetGLError());
|
| }
|
|
|
| @@ -1221,13 +1221,13 @@ TEST_P(GLES2DecoderManualInitTest, NoDefaultTexParameterfv) {
|
| EXPECT_EQ(error::kNoError, ExecuteCmd(cmd1));
|
| EXPECT_EQ(GL_NO_ERROR, GetGLError());
|
|
|
| - TexParameterfv cmd2;
|
| + GLfloat data = GL_NEAREST;
|
| + TexParameterfvImmediate& cmd2 =
|
| + *GetImmediateAs<TexParameterfvImmediate>();
|
| cmd2.Init(GL_TEXTURE_CUBE_MAP,
|
| GL_TEXTURE_MAG_FILTER,
|
| - shared_memory_id_,
|
| - shared_memory_offset_);
|
| - GetSharedMemoryAs<GLfloat*>()[0] = GL_NEAREST;
|
| - EXPECT_EQ(error::kNoError, ExecuteCmd(cmd2));
|
| + &data);
|
| + EXPECT_EQ(error::kNoError, ExecuteImmediateCmd(cmd2, sizeof(data)));
|
| EXPECT_EQ(GL_INVALID_VALUE, GetGLError());
|
| }
|
| }
|
| @@ -1244,13 +1244,13 @@ TEST_P(GLES2DecoderManualInitTest, NoDefaultTexParameteriv) {
|
| EXPECT_EQ(error::kNoError, ExecuteCmd(cmd1));
|
| EXPECT_EQ(GL_NO_ERROR, GetGLError());
|
|
|
| - TexParameteriv cmd2;
|
| + GLfloat data = GL_NEAREST;
|
| + TexParameterfvImmediate& cmd2 =
|
| + *GetImmediateAs<TexParameterfvImmediate>();
|
| cmd2.Init(GL_TEXTURE_2D,
|
| GL_TEXTURE_MAG_FILTER,
|
| - shared_memory_id_,
|
| - shared_memory_offset_);
|
| - GetSharedMemoryAs<GLint*>()[0] = GL_NEAREST;
|
| - EXPECT_EQ(error::kNoError, ExecuteCmd(cmd2));
|
| + &data);
|
| + EXPECT_EQ(error::kNoError, ExecuteImmediateCmd(cmd2, sizeof(data)));
|
| EXPECT_EQ(GL_INVALID_VALUE, GetGLError());
|
| }
|
|
|
| @@ -1261,13 +1261,13 @@ TEST_P(GLES2DecoderManualInitTest, NoDefaultTexParameteriv) {
|
| EXPECT_EQ(error::kNoError, ExecuteCmd(cmd1));
|
| EXPECT_EQ(GL_NO_ERROR, GetGLError());
|
|
|
| - TexParameteriv cmd2;
|
| + GLfloat data = GL_NEAREST;
|
| + TexParameterfvImmediate& cmd2 =
|
| + *GetImmediateAs<TexParameterfvImmediate>();
|
| cmd2.Init(GL_TEXTURE_CUBE_MAP,
|
| GL_TEXTURE_MAG_FILTER,
|
| - shared_memory_id_,
|
| - shared_memory_offset_);
|
| - GetSharedMemoryAs<GLint*>()[0] = GL_NEAREST;
|
| - EXPECT_EQ(error::kNoError, ExecuteCmd(cmd2));
|
| + &data);
|
| + EXPECT_EQ(error::kNoError, ExecuteImmediateCmd(cmd2, sizeof(data)));
|
| EXPECT_EQ(GL_INVALID_VALUE, GetGLError());
|
| }
|
| }
|
| @@ -1852,8 +1852,6 @@ TEST_P(GLES2DecoderTest, TextureUsageAngleExtNotEnabledByDefault) {
|
| TEST_P(GLES2DecoderTest, ProduceAndConsumeTextureCHROMIUM) {
|
| Mailbox mailbox = Mailbox::Generate();
|
|
|
| - memcpy(shared_memory_address_, mailbox.name, sizeof(mailbox.name));
|
| -
|
| DoBindTexture(GL_TEXTURE_2D, client_texture_id_, kServiceTextureId);
|
| DoTexImage2D(
|
| GL_TEXTURE_2D, 0, GL_RGBA, 3, 1, 0, GL_RGBA, GL_UNSIGNED_BYTE, 0, 0);
|
| @@ -1865,9 +1863,11 @@ TEST_P(GLES2DecoderTest, ProduceAndConsumeTextureCHROMIUM) {
|
| Texture* texture = texture_ref->texture();
|
| EXPECT_EQ(kServiceTextureId, texture->service_id());
|
|
|
| - ProduceTextureCHROMIUM produce_cmd;
|
| - produce_cmd.Init(GL_TEXTURE_2D, kSharedMemoryId, kSharedMemoryOffset);
|
| - EXPECT_EQ(error::kNoError, ExecuteCmd(produce_cmd));
|
| + ProduceTextureCHROMIUMImmediate& produce_cmd =
|
| + *GetImmediateAs<ProduceTextureCHROMIUMImmediate>();
|
| + produce_cmd.Init(GL_TEXTURE_2D, mailbox.name);
|
| + EXPECT_EQ(error::kNoError,
|
| + ExecuteImmediateCmd(produce_cmd, sizeof(mailbox.name)));
|
| EXPECT_EQ(GL_NO_ERROR, GetGLError());
|
|
|
| // Texture didn't change.
|
| @@ -1905,10 +1905,11 @@ TEST_P(GLES2DecoderTest, ProduceAndConsumeTextureCHROMIUM) {
|
| .Times(1)
|
| .RetiresOnSaturation();
|
|
|
| - memcpy(shared_memory_address_, mailbox.name, sizeof(mailbox.name));
|
| - ConsumeTextureCHROMIUM consume_cmd;
|
| - consume_cmd.Init(GL_TEXTURE_2D, kSharedMemoryId, kSharedMemoryOffset);
|
| - EXPECT_EQ(error::kNoError, ExecuteCmd(consume_cmd));
|
| + ConsumeTextureCHROMIUMImmediate& consume_cmd =
|
| + *GetImmediateAs<ConsumeTextureCHROMIUMImmediate>();
|
| + consume_cmd.Init(GL_TEXTURE_2D, mailbox.name);
|
| + EXPECT_EQ(error::kNoError,
|
| + ExecuteImmediateCmd(consume_cmd, sizeof(mailbox.name)));
|
| EXPECT_EQ(GL_NO_ERROR, GetGLError());
|
|
|
| // Texture is redefined.
|
|
|