Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: gpu/command_buffer/build_gles2_cmd_buffer.py

Issue 289993002: Remove shm versions of immediate commands from command buffer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@functions-with-extension-flag
Patch Set: try to avoid compiler warning on buffer overflow and template specialization linker problem with tw… Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gpu/command_buffer/client/gles2_cmd_helper_autogen.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/build_gles2_cmd_buffer.py
diff --git a/gpu/command_buffer/build_gles2_cmd_buffer.py b/gpu/command_buffer/build_gles2_cmd_buffer.py
index d918b73e75fe487ae7f9218507c2a6226dfaf03b..23a9b2bdf576aa0c83199d690ca4cb2146e4c210 100755
--- a/gpu/command_buffer/build_gles2_cmd_buffer.py
+++ b/gpu/command_buffer/build_gles2_cmd_buffer.py
@@ -2712,6 +2712,7 @@ class TypeHandler(object):
if immediate == True or immediate == None:
if func.num_pointer_args == 1 or immediate:
generator.AddFunction(ImmediateFunction(func))
+ return True
def AddBucketFunction(self, generator, func):
"""Adds a bucket version of a function."""
@@ -7312,8 +7313,8 @@ class GLGenerator(object):
gen_cmd = f.GetInfo('gen_cmd')
if gen_cmd == True or gen_cmd == None:
- self.AddFunction(f)
- f.type_handler.AddImmediateFunction(self, f)
+ if not f.type_handler.AddImmediateFunction(self, f):
+ self.AddFunction(f)
f.type_handler.AddBucketFunction(self, f)
self.Log("Auto Generated Functions : %d" %
« no previous file with comments | « no previous file | gpu/command_buffer/client/gles2_cmd_helper_autogen.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698