Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2899873002: Add shown user actions for the search engine promo. (Closed)

Created:
3 years, 7 months ago by Ted C
Modified:
3 years, 7 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add shown user actions for the search engine promo. BUG=724157 Review-Url: https://codereview.chromium.org/2899873002 Cr-Commit-Position: refs/heads/master@{#473938} Committed: https://chromium.googlesource.com/chromium/src/+/7e55c99e9413ad1689b59652ad7df1cadb792010

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/firstrun/DefaultSearchEngineFirstRunFragment.java View 2 chunks +29 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEnginePromoDialog.java View 2 chunks +6 lines, -0 lines 0 comments Download
M tools/metrics/actions/actions.xml View 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Ted C
PTAL
3 years, 7 months ago (2017-05-22 21:07:56 UTC) #2
Yusuf
lgtm
3 years, 7 months ago (2017-05-22 21:37:18 UTC) #3
Alexei Svitkine (slow)
lgtm
3 years, 7 months ago (2017-05-23 15:23:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2899873002/1
3 years, 7 months ago (2017-05-23 15:55:32 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 16:49:19 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7e55c99e9413ad1689b59652ad7d...

Powered by Google App Engine
This is Rietveld 408576698