chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEnginePromoDialog.java - Issue 2899873002: Add shown user actions for the search engine promo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEnginePromoDialog.java

Issue 2899873002: Add shown user actions for the search engine promo. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/firstrun/DefaultSearchEngineFirstRunFragment.java ('k') | tools/metrics/actions/actions.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEnginePromoDialog.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEnginePromoDialog.java b/chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEnginePromoDialog.java

index 945d74d0a76016a4b9b5386329ed4c15d5d9e0ab..f49b82d81b5c68441f9bf28002b474e03e7bdf48 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEnginePromoDialog.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEnginePromoDialog.java

@@ -13,6 +13,7 @@ import android.widget.Button;

import org.chromium.base.Callback;

import org.chromium.base.VisibleForTesting;

import org.chromium.base.library_loader.LibraryLoader;

+import org.chromium.base.metrics.RecordUserAction;

import org.chromium.chrome.R;

import org.chromium.chrome.browser.locale.LocaleManager.SearchEnginePromoType;

import org.chromium.chrome.browser.search_engines.TemplateUrlService;

@@ -106,6 +107,11 @@ public class DefaultSearchEnginePromoDialog extends PromoDialog {

@Override

public void show() {

super.show();

+ if (mDialogType == LocaleManager.SEARCH_ENGINE_PROMO_SHOW_NEW) {

+ RecordUserAction.record("SearchEnginePromo.NewDevice.Shown.Dialog");

+ } else if (mDialogType == LocaleManager.SEARCH_ENGINE_PROMO_SHOW_EXISTING) {

+ RecordUserAction.record("SearchEnginePromo.ExistingDevice.Shown.Dialog");

+ }

if (sObserver != null) sObserver.onDialogShown(this);

}