Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 2899813002: Use -fsanitize-address-use-after-scope on Windows (Closed)

Created:
3 years, 7 months ago by Reid Kleckner
Modified:
3 years, 7 months ago
Reviewers:
mmoroz
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use -fsanitize-address-use-after-scope on Windows Chromium's clang is new enough to understand this flag now. BUG=710928 R=mmoroz@chromium.org Review-Url: https://codereview.chromium.org/2899813002 Cr-Commit-Position: refs/heads/master@{#474024} Committed: https://chromium.googlesource.com/chromium/src/+/969478f127f1aff63d6bc934b0b11ee2d4703c64

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/config/sanitizers/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Reid Kleckner
3 years, 7 months ago (2017-05-22 17:42:22 UTC) #1
mmoroz
LGTM!
3 years, 7 months ago (2017-05-23 08:19:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2899813002/1
3 years, 7 months ago (2017-05-23 18:44:31 UTC) #4
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 20:13:38 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/969478f127f1aff63d6bc934b0b1...

Powered by Google App Engine
This is Rietveld 408576698