Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2675)

Unified Diff: build/config/sanitizers/BUILD.gn

Issue 2899813002: Use -fsanitize-address-use-after-scope on Windows (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/sanitizers/BUILD.gn
diff --git a/build/config/sanitizers/BUILD.gn b/build/config/sanitizers/BUILD.gn
index 78166cbde89308d996554c48f77a64ab8be9244d..59d927f7d1c9e94492ce42262e0820c279ecf0a7 100644
--- a/build/config/sanitizers/BUILD.gn
+++ b/build/config/sanitizers/BUILD.gn
@@ -318,9 +318,9 @@ config("asan_flags") {
cflags = []
if (is_asan) {
cflags += [ "-fsanitize=address" ]
- if (!is_mac && !is_win) {
+ if (!is_mac) {
cflags += [ "-fsanitize-address-use-after-scope" ]
- } else if (!is_win) {
+ } else {
# https://crbug.com/708707
cflags += [ "-fno-sanitize-address-use-after-scope" ]
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698