Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Unified Diff: components/ui_devtools/devtools_client.h

Issue 2899783002: Move DevTools out of ash and turn it to a component. (Closed)
Patch Set: Address nits. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ui_devtools/devtools_client.h
diff --git a/components/ui_devtools/devtools_client.h b/components/ui_devtools/devtools_client.h
index 1812556154966832f9c084cc061773b1a02333a2..70b5cafd6a967ca124e2e058061fd5b21f6d5d6b 100644
--- a/components/ui_devtools/devtools_client.h
+++ b/components/ui_devtools/devtools_client.h
@@ -11,6 +11,7 @@
#include "components/ui_devtools/Forward.h"
#include "components/ui_devtools/Protocol.h"
#include "components/ui_devtools/devtools_base_agent.h"
+#include "components/ui_devtools/devtools_export.h"
namespace ui {
blundell 2017/06/19 13:33:00 the namespace for this code should now be ui_devto
thanhph 2017/06/20 17:40:28 Done. I use ui_devtools namespace for all relevant
namespace devtools {
@@ -21,7 +22,7 @@ class UiDevToolsServer;
// this class and attach the corresponding backends/frontends (i.e: DOM, CSS,
// etc). This client is then attached to the UiDevToolsServer and all messages
// from this client are sent over the web socket owned by the server.
-class UiDevToolsClient : public protocol::FrontendChannel {
+class UI_DEVTOOLS_EXPORT UiDevToolsClient : public protocol::FrontendChannel {
public:
static const int kNotConnected = -1;

Powered by Google App Engine
This is Rietveld 408576698