components/ui_devtools/BUILD.gn - Issue 2899783002: Move DevTools out of ash and turn it to a component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ui_devtools/BUILD.gn

Issue 2899783002: Move DevTools out of ash and turn it to a component. (Closed)

Patch Set: Address nits. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/ui_devtools/BUILD.gn

diff --git a/components/ui_devtools/BUILD.gn b/components/ui_devtools/BUILD.gn

index eab5c09cbf97716c66fabef18e846737e6bea9d1..bb1d83b3bf23d1382e0bcf0b34a8dd64ad2ab12e 100644

--- a/components/ui_devtools/BUILD.gn

+++ b/components/ui_devtools/BUILD.gn

@@ -52,7 +52,7 @@ inspector_protocol_generate("protocol_generated_sources") {

outputs = _protocol_generated

}

-source_set("ui_devtools") {

+component("ui_devtools") {

blundell 2017/06/19 13:33:00 could you find some OWNERS for this component and

thanhph 2017/06/20 17:40:28 Done. I added a README.md. sadrul@ and dgozman@ ar

sources = rebase_path(_protocol_generated, ".", target_gen_dir)

sources += [

"devtools_base_agent.h",