Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2899763002: Measure usage of only CredentialRequestOptions.unmediated (Closed)

Created:
3 years, 7 months ago by jdoerrie
Modified:
3 years, 7 months ago
CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-frames_chromium.org, chromium-reviews, haraken
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Measure usage of only CredentialRequestOptions.unmediated This change adds a counter to measure usages of only providing CredentialRequestOptions.unmediated. BUG=721399 Review-Url: https://codereview.chromium.org/2899763002 Cr-Commit-Position: refs/heads/master@{#473858} Committed: https://chromium.googlesource.com/chromium/src/+/0bc5d1bef8d597ac40ba96d4e783fc4dd0bd4958

Patch Set 1 #

Patch Set 2 : Measure Usage of CredentialRequestOptions.mediation #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M tools/metrics/histograms/enums.xml View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (16 generated)
jdoerrie
Hi Mike, I just had a chat with Dominic where we decided it would be ...
3 years, 7 months ago (2017-05-22 14:16:17 UTC) #8
Mike West
lgtm
3 years, 7 months ago (2017-05-22 14:35:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2899763002/40001
3 years, 7 months ago (2017-05-22 15:02:24 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/433153)
3 years, 7 months ago (2017-05-22 17:01:33 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2899763002/40001
3 years, 7 months ago (2017-05-22 20:30:43 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/444095)
3 years, 7 months ago (2017-05-22 20:40:39 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2899763002/60001
3 years, 7 months ago (2017-05-23 09:24:29 UTC) #21
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 11:27:55 UTC) #24
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/0bc5d1bef8d597ac40ba96d4e783...

Powered by Google App Engine
This is Rietveld 408576698