third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp - Issue 2899763002: Measure usage of only CredentialRequestOptions.unmediated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp

Issue 2899763002: Measure usage of only CredentialRequestOptions.unmediated (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp

diff --git a/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp b/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp

index 014899736aefc4b60f8038c106d5a0e6e89bff97..5919c7496d9b07511c9d1a5cc7c0e3cc211f9d74 100644

--- a/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp

+++ b/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp

@@ -181,6 +181,9 @@ ScriptPromise CredentialsContainer::get(

String mediation = "optional";

if (options.hasUnmediated() && !options.hasMediation()) {

mediation = options.unmediated() ? "silent" : "optional";

+ UseCounter::Count(

+ context,

+ UseCounter::kCredentialManagerCredentialRequestOptionsOnlyUnmediated);

} else if (options.hasMediation()) {

mediation = options.mediation();

if (options.hasUnmediated() &&

« no previous file with comments | « third_party/WebKit/Source/core/frame/UseCounter.h ('k') | tools/metrics/histograms/enums.xml » ('j') | no next file with comments »