extensions/browser/api/declarative/declarative_api.cc - Issue 2899743002: Remove raw base::DictionaryValue::Set in //extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/declarative/declarative_api.cc

Issue 2899743002: Remove raw base::DictionaryValue::Set in //extensions (Closed)

Patch Set: Addressed nit Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/declarative/declarative_api.cc

diff --git a/extensions/browser/api/declarative/declarative_api.cc b/extensions/browser/api/declarative/declarative_api.cc

index 8a879579d4dafd198c9b4bdf27615e69e837ba0d..c9e4a735b4becfa563c9bc3d42a79d368852c701 100644

--- a/extensions/browser/api/declarative/declarative_api.cc

+++ b/extensions/browser/api/declarative/declarative_api.cc

@@ -130,7 +130,7 @@ void ConvertBinaryDictionaryValuesToBase64(base::DictionaryValue* dict) {

if (iter.value().IsType(base::Value::Type::BINARY)) {

base::Value* binary = NULL;

if (dict->GetBinary(iter.key(), &binary))

- dict->Set(iter.key(), ConvertBinaryToBase64(binary).release());

+ dict->Set(iter.key(), ConvertBinaryToBase64(binary));

} else if (iter.value().IsType(base::Value::Type::LIST)) {

const base::ListValue* list;

iter.value().GetAsList(&list);