Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: extensions/browser/api/app_window/app_window_api.cc

Issue 2899743002: Remove raw base::DictionaryValue::Set in //extensions (Closed)
Patch Set: Addressed nit Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/app_window/app_window_api.cc
diff --git a/extensions/browser/api/app_window/app_window_api.cc b/extensions/browser/api/app_window/app_window_api.cc
index 56962426cd3be9c1811fc088bb6b833077730bfe..0edbaef231864c172fec63d8dd6884efc01bd591 100644
--- a/extensions/browser/api/app_window/app_window_api.cc
+++ b/extensions/browser/api/app_window/app_window_api.cc
@@ -195,7 +195,7 @@ ExtensionFunction::ResponseAction AppWindowCreateFunction::Run() {
std::unique_ptr<base::DictionaryValue> result(
new base::DictionaryValue);
- result->Set("frameId", new base::Value(frame_id));
+ result->SetInteger("frameId", frame_id);
existing_window->GetSerializedState(result.get());
result->SetBoolean("existingWindow", true);
return RespondNow(OneArgument(std::move(result)));
@@ -376,8 +376,8 @@ ExtensionFunction::ResponseAction AppWindowCreateFunction::Run() {
frame_id = created_frame->GetRoutingID();
std::unique_ptr<base::DictionaryValue> result(new base::DictionaryValue);
- result->Set("frameId", new base::Value(frame_id));
- result->Set("id", new base::Value(app_window->window_key()));
+ result->SetInteger("frameId", frame_id);
+ result->SetString("id", app_window->window_key());
app_window->GetSerializedState(result.get());
ResponseValue result_arg = OneArgument(std::move(result));
« no previous file with comments | « extensions/browser/api/app_runtime/app_runtime_api.cc ('k') | extensions/browser/api/declarative/declarative_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698