extensions/browser/api/socket/socket_api.cc - Issue 2899743002: Remove raw base::DictionaryValue::Set in //extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/socket/socket_api.cc

Issue 2899743002: Remove raw base::DictionaryValue::Set in //extensions (Closed)

Patch Set: Addressed nit Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/socket/socket_api.cc

diff --git a/extensions/browser/api/socket/socket_api.cc b/extensions/browser/api/socket/socket_api.cc

index bb3d438f4fde2f2183ba88365c8d7ab7ba95d84e..cd52dff9fcbb206f8472653cf93df89274976f5a 100644

--- a/extensions/browser/api/socket/socket_api.cc

+++ b/extensions/browser/api/socket/socket_api.cc

@@ -522,7 +522,8 @@ void SocketReadFunction::OnCompleted(int bytes_read,

result->Set(kDataKey, base::Value::CreateWithCopiedBuffer(io_buffer->data(),

bytes_read));

} else {

- result->Set(kDataKey, new base::Value(base::Value::Type::BINARY));

+ result->Set(kDataKey,

+ base::MakeUnique<base::Value>(base::Value::Type::BINARY));

}

SetResult(std::move(result));