Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: extensions/browser/api/app_runtime/app_runtime_api.cc

Issue 2899743002: Remove raw base::DictionaryValue::Set in //extensions (Closed)
Patch Set: Addressed nit Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | extensions/browser/api/app_window/app_window_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/api/app_runtime/app_runtime_api.cc
diff --git a/extensions/browser/api/app_runtime/app_runtime_api.cc b/extensions/browser/api/app_runtime/app_runtime_api.cc
index b1093686210de1bdd487efd5403b9f44a81ea4d4..aeb5775b87f329e87f25afc6fe086dc9ca17f5cf 100644
--- a/extensions/browser/api/app_runtime/app_runtime_api.cc
+++ b/extensions/browser/api/app_runtime/app_runtime_api.cc
@@ -191,7 +191,7 @@ void AppRuntimeEventRouter::DispatchOnLaunchedEventWithFileEntries(
launch_item->SetBoolean("isDirectory", entries[i].is_directory);
items->Append(std::move(launch_item));
}
- launch_data->Set("items", items.release());
+ launch_data->Set("items", std::move(items));
DispatchOnLaunchedEventImpl(extension->id(), source_enum,
std::move(launch_data), context);
}
« no previous file with comments | « no previous file | extensions/browser/api/app_window/app_window_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698