Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2899643002: Generate enum/getters/setters/mappings for overflow-wrap. (Closed)

Created:
3 years, 7 months ago by shend
Modified:
3 years, 7 months ago
Reviewers:
meade_UTC10, rune
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Generate enum/getters/setters/mappings for overflow-wrap. Currently, the overflow-wrap property is a 'storage_only' field, so it has no generated public getters/setters. This patch changes it to a 'keyword' field so that its getters/setters can be generated as well. We also generate the EOverflowWrap enum and use the generated CSSValueID <-> EOverflowWrap mappings. Diff of generated files: https://gist.github.com/darrnshn/a1552b74d38cbb5d95479dd09fa8dd42/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2899643002 Cr-Commit-Position: refs/heads/master@{#474606} Committed: https://chromium.googlesource.com/chromium/src/+/8e06b59b53c3e02a64471ca3fb40f2e592b3d90d

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -33 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 1 chunk +0 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 chunk +0 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (10 generated)
shend
Hi Eddy, PTAL
3 years, 7 months ago (2017-05-24 00:01:07 UTC) #5
rune
lgtm
3 years, 7 months ago (2017-05-24 06:18:50 UTC) #9
meade_UTC10
lgtm
3 years, 7 months ago (2017-05-25 05:36:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2899643002/20001
3 years, 7 months ago (2017-05-25 06:22:40 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 08:26:51 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8e06b59b53c3e02a64471ca3fb40...

Powered by Google App Engine
This is Rietveld 408576698