Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issue 2899623003: Revert of Switch BrowserAccessibilityStateImpl to the TaskScheduler API. (Closed)

Created:
3 years, 7 months ago by Sébastien Marchand
Modified:
3 years, 7 months ago
Reviewers:
fdoray, dmazzoni, aboxhall
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, dougt+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Switch BrowserAccessibilityStateImpl to the TaskScheduler API. (patchset #3 id:40001 of https://codereview.chromium.org/2888773002/ ) Reason for revert: This is causing some issues on ChromeOS. See crbug.com/725247 Original issue's description: > Switch BrowserAccessibilityStateImpl to the TaskScheduler API. > > It doesn't look like the #if defined(OS_WIN) block is necessary here, everything could be handled by the task scheduler directly. > > BUG=689520 > > Review-Url: https://codereview.chromium.org/2888773002 > Cr-Commit-Position: refs/heads/master@{#473281} > Committed: https://chromium.googlesource.com/chromium/src/+/1e0346d1ef0851ad07bf00fafefdd747bf30baed TBR=dmazzoni@chromium.org,fdoray@chromium.org,aboxhall@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=689520 Review-Url: https://codereview.chromium.org/2899623003 Cr-Commit-Position: refs/heads/master@{#473777} Committed: https://chromium.googlesource.com/chromium/src/+/4c535159fa525e13b5e41282be4e99c5b62149e7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M content/browser/accessibility/browser_accessibility_state_impl.cc View 2 chunks +12 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Sébastien Marchand
Created Revert of Switch BrowserAccessibilityStateImpl to the TaskScheduler API.
3 years, 7 months ago (2017-05-23 00:41:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2899623003/1
3 years, 7 months ago (2017-05-23 00:42:37 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 01:38:56 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4c535159fa525e13b5e41282be4e...

Powered by Google App Engine
This is Rietveld 408576698