Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2888773002:
Switch BrowserAccessibilityStateImpl to the TaskScheduler API. (Closed)
|
Created:
3 years, 7 months ago by Sébastien Marchand Modified:
3 years, 7 months ago CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, dougt+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie, telemetry-reviews_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionSwitch BrowserAccessibilityStateImpl to the TaskScheduler API.
It doesn't look like the #if defined(OS_WIN) block is necessary here, everything could be handled by the task scheduler directly.
BUG=689520
Review-Url: https://codereview.chromium.org/2888773002
Cr-Commit-Position: refs/heads/master@{#473281}
Committed: https://chromium.googlesource.com/chromium/src/+/1e0346d1ef0851ad07bf00fafefdd747bf30baed
Patch Set 1 #Patch Set 2 : Rebase #Patch Set 3 : Add comment #Messages
Total messages: 38 (23 generated)
The CQ bit was checked by sebmarchand@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...) android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...) cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by sebmarchand@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Switch BrowserAccessibilityStateImpl to the TaskScheduler API. BUG=689520 ========== to ========== Switch BrowserAccessibilityStateImpl to the TaskScheduler API. It doesn't look like the #if defined(OS_WIN) block is necessary here, everything could be handled by the task scheduler directly. Additionaly, the base::TimeDelta::FromSeconds(ACCESSIBILITY_HISTOGRAM_DELAY_SECS) could probably be removed as this task has a BACKGROUND priority so the task scheduler won't run it during initialization. BUG=689520 ==========
sebmarchand@chromium.org changed reviewers: + dmazzoni@chromium.org
PTAL.
sebmarchand@chromium.org changed reviewers: + fdoray@chromium.org
+fdoray@ FYI
lgtm
sebmarchand@chromium.org changed reviewers: + aboxhall@chromium.org
+aboxhall@ for owner approval.
lgtm the delay is not just to avoid slowing startup, but also because assistive technology sometimes isn't detected until after the user interacts in some way, so a reasonable delay gives us better numbers. If we did change that, we'd have to update comments in tools/metrics/histograms/histograms.xml
Ha ok, I can add a comment about this delay while I'm here if you want.
Description was changed from ========== Switch BrowserAccessibilityStateImpl to the TaskScheduler API. It doesn't look like the #if defined(OS_WIN) block is necessary here, everything could be handled by the task scheduler directly. Additionaly, the base::TimeDelta::FromSeconds(ACCESSIBILITY_HISTOGRAM_DELAY_SECS) could probably be removed as this task has a BACKGROUND priority so the task scheduler won't run it during initialization. BUG=689520 ========== to ========== Switch BrowserAccessibilityStateImpl to the TaskScheduler API. It doesn't look like the #if defined(OS_WIN) block is necessary here, everything could be handled by the task scheduler directly. BUG=689520 ==========
The CQ bit was checked by sebmarchand@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from fdoray@chromium.org, dmazzoni@chromium.org Link to the patchset: https://codereview.chromium.org/2888773002/#ps40001 (title: "Add comment")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by sebmarchand@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by sebmarchand@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by sebmarchand@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495216408805870,
"parent_rev": "21107f7aaf8a03530821e5305a9a49edba1eb034", "commit_rev":
"1e0346d1ef0851ad07bf00fafefdd747bf30baed"}
Message was sent while issue was closed.
Description was changed from ========== Switch BrowserAccessibilityStateImpl to the TaskScheduler API. It doesn't look like the #if defined(OS_WIN) block is necessary here, everything could be handled by the task scheduler directly. BUG=689520 ========== to ========== Switch BrowserAccessibilityStateImpl to the TaskScheduler API. It doesn't look like the #if defined(OS_WIN) block is necessary here, everything could be handled by the task scheduler directly. BUG=689520 Review-Url: https://codereview.chromium.org/2888773002 Cr-Commit-Position: refs/heads/master@{#473281} Committed: https://chromium.googlesource.com/chromium/src/+/1e0346d1ef0851ad07bf00fafefd... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/1e0346d1ef0851ad07bf00fafefd...
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2899623003/ by sebmarchand@chromium.org. The reason for reverting is: This is causing some issues on ChromeOS. See crbug.com/725247. |
