Clean up remaining uses of ASSERT in core

Clean up remaining uses of ASSERT in core

As a step to reduce uses of wtf/Assertions.h, This CL changes all uses of ASSERT with
DCHECK() or DCHECK_FOO() in core.

BUG=596760
Review-Url: https://codereview.chromium.org/2899573002
Cr-Commit-Position: refs/heads/master@{#473464}
Committed: https://chromium.googlesource.com/chromium/src/+/9b65c469423afabf0a29df2dfbf04db9b2a209eb

[gyuyoung, 2017-05-20 09:10:33]

gyuyoung@igalia.com changed reviewers:
+ haraken@chromium.org, tkent@chromium.org

[gyuyoung, 2017-05-20 09:10:34]

PTAL.

[haraken, 2017-05-20 10:10:22]

LGTM

https://codereview.chromium.org/2899573002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/page/SpatialNavigation.cpp (right):

https://codereview.chromium.org/2899573002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/page/SpatialNavigation.cpp:411: DCHECK(node &&
node->GetLayoutObject());

Split it into two dchecks.

[gyuyoung, 2017-05-21 00:35:04]

https://codereview.chromium.org/2899573002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/page/SpatialNavigation.cpp (right):

https://codereview.chromium.org/2899573002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/page/SpatialNavigation.cpp:411: DCHECK(node &&
node->GetLayoutObject());
On 2017/05/20 10:10:22, haraken wrote:
> 
> Split it into two dchecks.

Done.

[gyuyoung, 2017-05-21 00:35:14]

The CQ bit was checked by gyuyoung@igalia.com

[gyuyoung, 2017-05-21 00:35:14]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2899573002/#ps20001
(title: "Clean up remaining uses of ASSERT in core")

[commit-bot: I haz the power, 2017-05-21 00:35:26]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-21 01:01:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-21 01:01:53]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[gyuyoung, 2017-05-21 06:30:56]

The CQ bit was checked by gyuyoung@igalia.com

[gyuyoung, 2017-05-21 06:30:57]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2899573002/#ps40001
(title: "Clean up remaining uses of ASSERT in core")

[gyuyoung, 2017-05-21 06:31:05]

The CQ bit was unchecked by gyuyoung@igalia.com

[commit-bot: I haz the power, 2017-05-21 06:31:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gyuyoung, 2017-05-21 06:31:26]

The CQ bit was checked by gyuyoung@igalia.com

[commit-bot: I haz the power, 2017-05-21 06:31:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-21 09:05:05]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495348286144630,
"parent_rev": "f9e53d2729cf58dbf5773c7438cbd1fb90df40ab", "commit_rev":
"9b65c469423afabf0a29df2dfbf04db9b2a209eb"}

[commit-bot: I haz the power, 2017-05-21 09:05:18]

Description was changed from

==========
Clean up remaining uses of ASSERT in core

As a step to reduce uses of wtf/Assertions.h, This CL changes all uses of ASSERT
with
DCHECK() or DCHECK_FOO() in core.

BUG=596760
==========

to

==========
Clean up remaining uses of ASSERT in core

As a step to reduce uses of wtf/Assertions.h, This CL changes all uses of ASSERT
with
DCHECK() or DCHECK_FOO() in core.

BUG=596760

Review-Url: https://codereview.chromium.org/2899573002
Cr-Commit-Position: refs/heads/master@{#473464}
Committed:
https://chromium.googlesource.com/chromium/src/+/9b65c469423afabf0a29df2dfbf0...
==========

[commit-bot: I haz the power, 2017-05-21 09:05:20]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9b65c469423afabf0a29df2dfbf0...