Clean up remaining uses of ASSERT in core

third_party/WebKit/Source/core/page/CreateWindow.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 112 matching lines @@
   return &frame;
 }
 
 static Frame* CreateWindowHelper(LocalFrame& opener_frame,
                                  LocalFrame& active_frame,
                                  LocalFrame& lookup_frame,
                                  const FrameLoadRequest& request,
                                  const WindowFeatures& features,
                                  NavigationPolicy policy,
                                  bool& created) {
-  ASSERT(!features.dialog || request.FrameName().IsEmpty());
-  ASSERT(request.GetResourceRequest().RequestorOrigin() ||
+  DCHECK(!features.dialog || request.FrameName().IsEmpty());
+  DCHECK(request.GetResourceRequest().RequestorOrigin() ||
          opener_frame.GetDocument()->Url().IsEmpty());
-  ASSERT(request.GetResourceRequest().GetFrameType() ==
-         WebURLRequest::kFrameTypeAuxiliary);
+  DCHECK_EQ(request.GetResourceRequest().GetFrameType(),
+            WebURLRequest::kFrameTypeAuxiliary);
 
   created = false;
 
   Frame* window = features.noopener
                       ? nullptr
                       : ReuseExistingWindow(active_frame, lookup_frame,
                                             request.FrameName(), policy);
 
   if (!window) {
     // Sandboxed frames cannot open new auxiliary browsing contexts.
@@ skipping 104 matching lines @@
     new_frame->Navigate(*calling_window.document(), completed_url, false,
                         has_user_gesture ? UserGestureStatus::kActive
                                          : UserGestureStatus::kNone);
   }
   return new_frame->DomWindow();
 }
 
 void CreateWindowForRequest(const FrameLoadRequest& request,
                             LocalFrame& opener_frame,
                             NavigationPolicy policy) {
-  ASSERT(request.GetResourceRequest().RequestorOrigin() ||
+  DCHECK(request.GetResourceRequest().RequestorOrigin() ||
          (opener_frame.GetDocument() &&
           opener_frame.GetDocument()->Url().IsEmpty()));
 
   if (opener_frame.GetDocument()->PageDismissalEventBeingDispatched() !=
       Document::kNoDismissal)
     return;
 
   if (opener_frame.GetDocument() &&
       opener_frame.GetDocument()->IsSandboxed(kSandboxPopups))
     return;
@@ skipping 20 matching lines @@
   }
 
   // TODO(japhet): Form submissions on RemoteFrames don't work yet.
   FrameLoadRequest new_request(0, request.GetResourceRequest());
   new_request.SetForm(request.Form());
   if (new_frame->IsLocalFrame())
     ToLocalFrame(new_frame)->Loader().Load(new_request);
 }
 
 }  // namespace blink