Views/Harmony Remove references to ui/views/layout/layout_constants.h

Views/Harmony Remove references to ui/views/layout/layout_constants.h

Replace references to constants in ui/views/layout/layout_constants.h with their
equivalents using ChromeLayoutProvider.

BUG=691897
Review-Url: https://codereview.chromium.org/2899523002
Cr-Commit-Position: refs/heads/master@{#473398}
Committed: https://chromium.googlesource.com/chromium/src/+/a964ee167eddaf2c533ad6dd269c4f9926abf473

[ananta, 2017-05-19 23:16:20]

ananta@chromium.org changed reviewers:
+ pkasting@chromium.org

[ananta, 2017-05-19 23:16:34]

The CQ bit was checked by ananta@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 23:17:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Kasting, 2017-05-19 23:45:44]

LGTM with comment

https://codereview.chromium.org/2899523002/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc (right):

https://codereview.chromium.org/2899523002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc:220: 0,
provider->GetDistanceMetric(DISTANCE_UNRELATED_CONTROL_HORIZONTAL));
This passes a horizontal metric value to a call using it for vertical spacing.

It looks to me like this should be using the top() of INSETS_PANEL, since it's
faking a dialog title.

[ananta, 2017-05-20 00:02:02]

https://codereview.chromium.org/2899523002/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc (right):

https://codereview.chromium.org/2899523002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc:220: 0,
provider->GetDistanceMetric(DISTANCE_UNRELATED_CONTROL_HORIZONTAL));
On 2017/05/19 23:45:44, Peter Kasting wrote:
> This passes a horizontal metric value to a call using it for vertical spacing.
> 
> It looks to me like this should be using the top() of INSETS_PANEL, since it's
> faking a dialog title.

Thanks done.

[ananta, 2017-05-20 00:02:35]

The CQ bit was checked by ananta@chromium.org

[ananta, 2017-05-20 00:02:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2899523002/#ps60001
(title: "Address review comments")

[commit-bot: I haz the power, 2017-05-20 00:03:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-20 01:05:29]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495238555084670,
"parent_rev": "3b77f4e721998b5fb72fd1039b14e926823527b8", "commit_rev":
"a964ee167eddaf2c533ad6dd269c4f9926abf473"}

[commit-bot: I haz the power, 2017-05-20 01:05:40]

Description was changed from

==========
Views/Harmony Remove references to ui/views/layout/layout_constants.h

Replace references to constants in ui/views/layout/layout_constants.h with their
equivalents using ChromeLayoutProvider.

BUG=691897
==========

to

==========
Views/Harmony Remove references to ui/views/layout/layout_constants.h

Replace references to constants in ui/views/layout/layout_constants.h with their
equivalents using ChromeLayoutProvider.

BUG=691897

Review-Url: https://codereview.chromium.org/2899523002
Cr-Commit-Position: refs/heads/master@{#473398}
Committed:
https://chromium.googlesource.com/chromium/src/+/a964ee167eddaf2c533ad6dd269c...
==========

[commit-bot: I haz the power, 2017-05-20 01:05:41]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/a964ee167eddaf2c533ad6dd269c...