Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: chrome/browser/ui/views/autofill/save_card_bubble_views.cc

Issue 2899523002: Views/Harmony Remove references to ui/views/layout/layout_constants.h (Closed)
Patch Set: Address review comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/autofill/save_card_bubble_views.h" 5 #include "chrome/browser/ui/views/autofill/save_card_bubble_views.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
11 #include "build/build_config.h" 11 #include "build/build_config.h"
12 #include "chrome/browser/ui/browser_dialogs.h" 12 #include "chrome/browser/ui/browser_dialogs.h"
13 #include "chrome/browser/ui/views/autofill/view_util.h" 13 #include "chrome/browser/ui/views/autofill/view_util.h"
14 #include "chrome/browser/ui/views/harmony/chrome_layout_provider.h"
14 #include "components/autofill/core/browser/credit_card.h" 15 #include "components/autofill/core/browser/credit_card.h"
15 #include "components/autofill/core/browser/legal_message_line.h" 16 #include "components/autofill/core/browser/legal_message_line.h"
16 #include "components/autofill/core/browser/ui/save_card_bubble_controller.h" 17 #include "components/autofill/core/browser/ui/save_card_bubble_controller.h"
17 #include "components/strings/grit/components_strings.h" 18 #include "components/strings/grit/components_strings.h"
18 #include "ui/base/l10n/l10n_util.h" 19 #include "ui/base/l10n/l10n_util.h"
19 #include "ui/base/resource/resource_bundle.h" 20 #include "ui/base/resource/resource_bundle.h"
20 #include "ui/views/border.h" 21 #include "ui/views/border.h"
21 #include "ui/views/bubble/bubble_frame_view.h" 22 #include "ui/views/bubble/bubble_frame_view.h"
22 #include "ui/views/controls/button/blue_button.h" 23 #include "ui/views/controls/button/blue_button.h"
23 #include "ui/views/controls/button/label_button.h" 24 #include "ui/views/controls/button/label_button.h"
24 #include "ui/views/controls/label.h" 25 #include "ui/views/controls/label.h"
25 #include "ui/views/controls/link.h" 26 #include "ui/views/controls/link.h"
26 #include "ui/views/controls/styled_label.h" 27 #include "ui/views/controls/styled_label.h"
27 #include "ui/views/controls/textfield/textfield.h" 28 #include "ui/views/controls/textfield/textfield.h"
28 #include "ui/views/layout/box_layout.h" 29 #include "ui/views/layout/box_layout.h"
29 #include "ui/views/layout/layout_constants.h"
30 #include "ui/views/window/dialog_client_view.h" 30 #include "ui/views/window/dialog_client_view.h"
31 31
32 namespace autofill { 32 namespace autofill {
33 33
34 namespace { 34 namespace {
35 35
36 // Fixed width of the bubble, in dip. 36 // Fixed width of the bubble, in dip.
37 const int kBubbleWidth = 395; 37 const int kBubbleWidth = 395;
38 38
39 std::unique_ptr<views::StyledLabel> CreateLegalMessageLineLabel( 39 std::unique_ptr<views::StyledLabel> CreateLegalMessageLineLabel(
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
175 } 175 }
176 } 176 }
177 177
178 // |range| was not found. 178 // |range| was not found.
179 NOTREACHED(); 179 NOTREACHED();
180 } 180 }
181 181
182 // Create view containing everything except for the footnote. 182 // Create view containing everything except for the footnote.
183 std::unique_ptr<views::View> SaveCardBubbleViews::CreateMainContentView() { 183 std::unique_ptr<views::View> SaveCardBubbleViews::CreateMainContentView() {
184 std::unique_ptr<View> view(new View()); 184 std::unique_ptr<View> view(new View());
185 view->SetLayoutManager( 185 ChromeLayoutProvider* provider = ChromeLayoutProvider::Get();
186 new views::BoxLayout(views::BoxLayout::kVertical, 0, 0, 186
187 views::kUnrelatedControlVerticalSpacing)); 187 view->SetLayoutManager(new views::BoxLayout(
188 views::BoxLayout::kVertical, 0, 0,
189 provider->GetDistanceMetric(DISTANCE_UNRELATED_CONTROL_VERTICAL)));
188 190
189 // Add the card type icon, last four digits and expiration date. 191 // Add the card type icon, last four digits and expiration date.
190 views::View* description_view = new views::View(); 192 views::View* description_view = new views::View();
191 description_view->SetLayoutManager(new views::BoxLayout( 193 description_view->SetLayoutManager(new views::BoxLayout(
192 views::BoxLayout::kHorizontal, 0, 0, views::kRelatedButtonHSpacing)); 194 views::BoxLayout::kHorizontal, 0, 0,
195 provider->GetDistanceMetric(views::DISTANCE_RELATED_BUTTON_HORIZONTAL)));
193 view->AddChildView(description_view); 196 view->AddChildView(description_view);
194 197
195 const CreditCard& card = controller_->GetCard(); 198 const CreditCard& card = controller_->GetCard();
196 views::ImageView* card_type_icon = new views::ImageView(); 199 views::ImageView* card_type_icon = new views::ImageView();
197 card_type_icon->SetImage( 200 card_type_icon->SetImage(
198 ResourceBundle::GetSharedInstance() 201 ResourceBundle::GetSharedInstance()
199 .GetImageNamed(CreditCard::IconResourceId(card.network())) 202 .GetImageNamed(CreditCard::IconResourceId(card.network()))
200 .AsImageSkia()); 203 .AsImageSkia());
201 card_type_icon->SetTooltipText(card.NetworkForDisplay()); 204 card_type_icon->SetTooltipText(card.NetworkForDisplay());
202 card_type_icon->SetBorder( 205 card_type_icon->SetBorder(
(...skipping 16 matching lines...) Expand all
219 explanation_label->SetMultiLine(true); 222 explanation_label->SetMultiLine(true);
220 explanation_label->SetHorizontalAlignment(gfx::ALIGN_LEFT); 223 explanation_label->SetHorizontalAlignment(gfx::ALIGN_LEFT);
221 view->AddChildView(explanation_label); 224 view->AddChildView(explanation_label);
222 } 225 }
223 226
224 return view; 227 return view;
225 } 228 }
226 229
227 std::unique_ptr<views::View> SaveCardBubbleViews::CreateRequestCvcView() { 230 std::unique_ptr<views::View> SaveCardBubbleViews::CreateRequestCvcView() {
228 std::unique_ptr<View> request_cvc_view = base::MakeUnique<views::View>(); 231 std::unique_ptr<View> request_cvc_view = base::MakeUnique<views::View>();
229 request_cvc_view->SetLayoutManager(new views::BoxLayout( 232 request_cvc_view->SetLayoutManager(
230 views::BoxLayout::kHorizontal, 0, 0, views::kRelatedButtonHSpacing)); 233 new views::BoxLayout(views::BoxLayout::kHorizontal, 0, 0,
234 ChromeLayoutProvider::Get()->GetDistanceMetric(
235 views::DISTANCE_RELATED_BUTTON_HORIZONTAL)));
231 236
232 DCHECK(!cvc_textfield_); 237 DCHECK(!cvc_textfield_);
233 cvc_textfield_ = CreateCvcTextfield(); 238 cvc_textfield_ = CreateCvcTextfield();
234 cvc_textfield_->set_controller(this); 239 cvc_textfield_->set_controller(this);
235 request_cvc_view->AddChildView(cvc_textfield_); 240 request_cvc_view->AddChildView(cvc_textfield_);
236 241
237 views::ImageView* cvc_image = new views::ImageView(); 242 views::ImageView* cvc_image = new views::ImageView();
238 ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance(); 243 ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
239 cvc_image->SetImage( 244 cvc_image->SetImage(
240 rb.GetImageSkiaNamed(controller_->GetCvcImageResourceId())); 245 rb.GetImageSkiaNamed(controller_->GetCvcImageResourceId()));
(...skipping 18 matching lines...) Expand all
259 DCHECK_EQ(cvc_textfield_, sender); 264 DCHECK_EQ(cvc_textfield_, sender);
260 GetDialogClientView()->UpdateDialogButtons(); 265 GetDialogClientView()->UpdateDialogButtons();
261 } 266 }
262 267
263 void SaveCardBubbleViews::Init() { 268 void SaveCardBubbleViews::Init() {
264 SetLayoutManager(new views::BoxLayout(views::BoxLayout::kVertical, 0, 0, 0)); 269 SetLayoutManager(new views::BoxLayout(views::BoxLayout::kVertical, 0, 0, 0));
265 AddChildView(CreateMainContentView().release()); 270 AddChildView(CreateMainContentView().release());
266 } 271 }
267 272
268 } // namespace autofill 273 } // namespace autofill
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/accessibility/invert_bubble_view.cc ('k') | chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698