Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2969)

Issue 2899413003: [DMC #13] Don't create RenderedDocumentMarkers in SpellCheckMarkerListImpl (Closed)

Created:
3 years, 7 months ago by rlanday
Modified:
3 years, 7 months ago
Reviewers:
yosin_UTC9, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't create RenderedDocumentMarkers in SpellCheckMarkerListImpl I meant to do this as part of https://codereview.chromium.org/2883503004 but forgot that we have a custom Add() method in SpellCheckMarkerListImpl. Oops BUG=707867 Review-Url: https://codereview.chromium.org/2899413003 Cr-Commit-Position: refs/heads/master@{#474607} Committed: https://chromium.googlesource.com/chromium/src/+/4b005061f90a81b14985fb155be147b5607f5245

Patch Set 1 #

Patch Set 2 : Remove dep #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListImpl.cpp View 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
rlanday
3 years, 7 months ago (2017-05-24 22:06:46 UTC) #3
yosin_UTC9
lgtm
3 years, 7 months ago (2017-05-25 05:19:26 UTC) #8
commit-bot: I haz the power
This CL has an open dependency (Issue 2900573002 Patch 100001). Please resolve the dependency and ...
3 years, 7 months ago (2017-05-25 05:19:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2899413003/20001
3 years, 7 months ago (2017-05-25 06:46:28 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 08:34:04 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4b005061f90a81b14985fb155be1...

Powered by Google App Engine
This is Rietveld 408576698