Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2899403002: Change QuicHttpStream to Reset the upload data stream even if the (Closed)

Created:
3 years, 7 months ago by Ryan Hamilton
Modified:
3 years, 7 months ago
Reviewers:
Zhongyi Shi
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change QuicHttpStream to Reset the upload data stream even if the underlying QUIC stream is null. Fix some tests in which the UploadDataStream did not outlive the QuicHttpStream. BUG=716563 Review-Url: https://codereview.chromium.org/2899403002 Cr-Commit-Position: refs/heads/master@{#474479} Committed: https://chromium.googlesource.com/chromium/src/+/97827ee523ac3f3f1d3b8b7c84b0c1fc13fc651b

Patch Set 1 #

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -31 lines) Patch
M net/quic/chromium/quic_http_stream.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M net/quic/chromium/quic_http_stream_test.cc View 1 14 chunks +38 lines, -26 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Ryan Hamilton
3 years, 7 months ago (2017-05-24 21:21:12 UTC) #2
Zhongyi Shi
lgtm
3 years, 7 months ago (2017-05-24 22:07:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2899403002/20001
3 years, 7 months ago (2017-05-24 23:43:49 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 23:49:28 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/97827ee523ac3f3f1d3b8b7c84b0...

Powered by Google App Engine
This is Rietveld 408576698