Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: net/quic/chromium/quic_http_stream.cc

Issue 2899403002: Change QuicHttpStream to Reset the upload data stream even if the (Closed)
Patch Set: cleanup Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/chromium/quic_http_stream_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/chromium/quic_http_stream.cc
diff --git a/net/quic/chromium/quic_http_stream.cc b/net/quic/chromium/quic_http_stream.cc
index d7a0a739955f1636b6b8982e282dcbda5a7a132b..cdddc26e7f480127304d80770ac6722608edb29b 100644
--- a/net/quic/chromium/quic_http_stream.cc
+++ b/net/quic/chromium/quic_http_stream.cc
@@ -776,6 +776,12 @@ void QuicHttpStream::ResetStream() {
push_handle_->Cancel();
push_handle_ = nullptr;
}
+
+ // If |request_body_stream_| is non-NULL, Reset it, to abort any in progress
+ // read.
+ if (request_body_stream_)
+ request_body_stream_->Reset();
+
if (!stream_)
return;
DCHECK_LE(stream_->NumBytesConsumed(), stream_->stream_bytes_read());
@@ -785,11 +791,6 @@ void QuicHttpStream::ResetStream() {
closed_is_first_stream_ = stream_->IsFirstStream();
stream_->ClearDelegate();
stream_ = nullptr;
-
- // If |request_body_stream_| is non-NULL, Reset it, to abort any in progress
- // read.
- if (request_body_stream_)
- request_body_stream_->Reset();
}
int QuicHttpStream::GetResponseStatus() {
« no previous file with comments | « no previous file | net/quic/chromium/quic_http_stream_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698