[Mac] Fix incorrect profile type passed to new browser window.

[Mac] Fix incorrect profile type passed to new browser window.

Crash reports for https://crbug.com/723414 show a crash in a CHECK()
of profile type being used to create a new browser window via
Browser::Browser(), specicially:

  CHECK(!profile_->IsGuestSession() || profile_->IsOffTheRecord())
      << "Only off the record browser may be opened in guest mode";

Thi cl changes the caller to pass a profile safe for Browser::Browser()
to use.

R=avi@chromium.org
BUG=723414
Review-Url: https://codereview.chromium.org/2899313005
Cr-Commit-Position: refs/heads/master@{#474799}
Committed: https://chromium.googlesource.com/chromium/src/+/262de4db50be5c113ac5475f229dfa88834314ce

[shrike, 2017-05-25 20:20:03]

Hello avi@,

I have you as an owner reviewer for this cl - would you also be a good person to
review this change? I'm not knowledgeable on browser profiles, etc., but am
taking a guess that my change fixes the crasher. If you're not a good person,
can you suggest a good reviewer?

[Avi (use Gerrit), 2017-05-25 20:26:39]

LGTM

Going by referencing https://codereview.chromium.org/230923004 which introduced
-safeLastProfileForNewWindows.

[shrike, 2017-05-25 20:29:21]

On 2017/05/25 20:26:39, Avi (ping after 24h) wrote:
> LGTM
> 
> Going by referencing https://codereview.chromium.org/230923004 which
introduced
> -safeLastProfileForNewWindows.

Thank you.

[shrike, 2017-05-25 20:29:24]

The CQ bit was checked by shrike@chromium.org

[commit-bot: I haz the power, 2017-05-25 20:30:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 20:54:35]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495744164901230, "parent_rev":
"be8885d7172d99cd8fff3a6782bd2aeac4a10371", "commit_rev":
"262de4db50be5c113ac5475f229dfa88834314ce"}

[commit-bot: I haz the power, 2017-05-25 20:54:53]

Description was changed from

==========
[Mac] Fix incorrect profile type passed to new browser window.

Crash reports for https://crbug.com/723414 show a crash in a CHECK()
of profile type being used to create a new browser window via
Browser::Browser(), specicially:

  CHECK(!profile_->IsGuestSession() || profile_->IsOffTheRecord())
      << "Only off the record browser may be opened in guest mode";

Thi cl changes the caller to pass a profile safe for Browser::Browser()
to use.

R=avi@chromium.org
BUG=723414
==========

to

==========
[Mac] Fix incorrect profile type passed to new browser window.

Crash reports for https://crbug.com/723414 show a crash in a CHECK()
of profile type being used to create a new browser window via
Browser::Browser(), specicially:

  CHECK(!profile_->IsGuestSession() || profile_->IsOffTheRecord())
      << "Only off the record browser may be opened in guest mode";

Thi cl changes the caller to pass a profile safe for Browser::Browser()
to use.

R=avi@chromium.org
BUG=723414

Review-Url: https://codereview.chromium.org/2899313005
Cr-Commit-Position: refs/heads/master@{#474799}
Committed:
https://chromium.googlesource.com/chromium/src/+/262de4db50be5c113ac5475f229d...
==========

[commit-bot: I haz the power, 2017-05-25 20:54:54]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/262de4db50be5c113ac5475f229d...