Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Issue 230923004: Use OffTheRecord version when using Guest profiles to handle commands. (Closed)

Created:
6 years, 8 months ago by bcwhite
Modified:
6 years, 8 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Use OffTheRecord version when using Guest profiles to handle commands. BUG=359970 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262944

Patch Set 1 #

Patch Set 2 : moved guest test to separate method and called in a couple more places #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M chrome/browser/app_controller_mac.mm View 1 4 chunks +13 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
bcwhite
6 years, 8 months ago (2014-04-09 16:52:33 UTC) #1
Lei Zhang
lgtm Are there more guest session profile changes like this to make in this file?
6 years, 8 months ago (2014-04-09 17:36:29 UTC) #2
bcwhite
On 2014/04/09 17:36:29, Lei Zhang wrote: > lgtm > > Are there more guest session ...
6 years, 8 months ago (2014-04-09 18:16:56 UTC) #3
Lei Zhang
Still lgtm On Apr 9, 2014 11:16 AM, <bcwhite@chromium.org> wrote: > On 2014/04/09 17:36:29, Lei ...
6 years, 8 months ago (2014-04-09 18:49:52 UTC) #4
bcwhite
The CQ bit was checked by bcwhite@chromium.org
6 years, 8 months ago (2014-04-10 03:37:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bcwhite@chromium.org/230923004/20001
6 years, 8 months ago (2014-04-10 03:37:39 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 05:46:27 UTC) #7
Message was sent while issue was closed.
Change committed as 262944

Powered by Google App Engine
This is Rietveld 408576698