[Payments] Move the logging for checkout flow to native.

[Payments] Move the logging for checkout flow to native.

BUG=726469
Review-Url: https://codereview.chromium.org/2899313002
Cr-Commit-Position: refs/heads/master@{#475001}
Committed: https://chromium.googlesource.com/chromium/src/+/f8272a2043eeddf86177a2c643215d5060066122

[sebsg, 2017-05-24 18:42:15]

The CQ bit was checked by sebsg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 18:43:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 18:52:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 18:52:42]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sebsg, 2017-05-24 18:54:41]

Patchset #1 (id:1) has been deleted

[sebsg, 2017-05-24 19:35:18]

The CQ bit was checked by sebsg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 19:35:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 19:38:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 19:38:55]

Dry run: Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sebsg, 2017-05-24 19:52:37]

The CQ bit was checked by sebsg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 19:53:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sebsg, 2017-05-24 19:55:55]

Patchset #1 (id:20001) has been deleted

[commit-bot: I haz the power, 2017-05-24 19:56:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 19:56:47]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[sebsg, 2017-05-24 20:30:49]

The CQ bit was checked by sebsg@chromium.org to run a CQ dry run

[sebsg, 2017-05-24 20:31:09]

Patchset #2 (id:60001) has been deleted

[commit-bot: I haz the power, 2017-05-24 20:31:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 20:34:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 20:34:40]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sebsg, 2017-05-24 21:13:07]

The CQ bit was checked by sebsg@chromium.org to run a CQ dry run

[sebsg, 2017-05-24 21:13:17]

Patchset #2 (id:80001) has been deleted

[commit-bot: I haz the power, 2017-05-24 21:13:52]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 03:08:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 03:08:50]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[sebsg, 2017-05-25 13:40:55]

The CQ bit was checked by sebsg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 13:41:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sebsg, 2017-05-25 13:59:54]

Patchset #2 (id:100001) has been deleted

[sebsg, 2017-05-25 14:00:03]

Patchset #1 (id:40001) has been deleted

[sebsg, 2017-05-25 14:15:34]

The CQ bit was checked by sebsg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 14:15:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sebsg, 2017-05-25 14:15:47]

Patchset #1 (id:120001) has been deleted

[sebsg, 2017-05-25 14:16:30]

sebsg@chromium.org changed reviewers:
+ gogerald@chromium.org, mathp@chromium.org

[sebsg, 2017-05-25 14:16:31]

Hi guys, could you please take a look?

[commit-bot: I haz the power, 2017-05-25 15:21:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 15:21:12]

Dry run: This issue passed the CQ dry run.

[sebsg, 2017-05-25 20:43:08]

Description was changed from

==========
[Payments] Move the logging for checkout flow to native.

BUG=
==========

to

==========
[Payments] Move the logging for checkout flow to native.

BUG=726469
==========

[Mathieu, 2017-05-25 20:48:10]

Pretty straightforward, thanks! lgtm

https://codereview.chromium.org/2899313002/diff/140001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/JourneyLogger.java
(right):

https://codereview.chromium.org/2899313002/diff/140001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/JourneyLogger.java:216:
assert !mWasShowCalled;
are these equivalent to DCHECKs? because you're rechecking the information below

[sebsg, 2017-05-25 20:56:24]

Thanks math,

gogerald, could you please take a look? Thanks!

https://codereview.chromium.org/2899313002/diff/140001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/JourneyLogger.java
(right):

https://codereview.chromium.org/2899313002/diff/140001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/JourneyLogger.java:216:
assert !mWasShowCalled;
On 2017/05/25 20:48:10, Mathieu wrote:
> are these equivalent to DCHECKs? because you're rechecking the information
below

Yep, they are like DCHECK :)

[gogerald1, 2017-05-25 22:20:07]

https://codereview.chromium.org/2899313002/diff/140001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/JourneyLogger.java
(right):

https://codereview.chromium.org/2899313002/diff/140001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/JourneyLogger.java:57:
public static final int ABORT_REASON_ABORTED_BY_USER = 0;
have you considered automatically generate enum in C++ side to java side? It is
easier to maintain in that way, refer here for reference
https://cs.chromium.org/chromium/src/components/signin/core/browser/signin_me...

https://codereview.chromium.org/2899313002/diff/140001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/JourneyLogger.java:195:
* @param submissionType An int indicating why the payment request was aborted.
@param reason?

https://codereview.chromium.org/2899313002/diff/140001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/JourneyLogger.java:212:
* @param submissionType An int indicating why the payment request was not shown.
@param reason?

https://codereview.chromium.org/2899313002/diff/140001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestMetrics.java
(right):

https://codereview.chromium.org/2899313002/diff/140001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestMetrics.java:13:
public final class PaymentRequestMetrics {
Do we have plan to move the rest of the metrics in this file to native side as
well?

[sebsg, 2017-05-26 13:12:22]

Thanks! Another look?

https://codereview.chromium.org/2899313002/diff/140001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/JourneyLogger.java
(right):

https://codereview.chromium.org/2899313002/diff/140001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/JourneyLogger.java:57:
public static final int ABORT_REASON_ABORTED_BY_USER = 0;
On 2017/05/25 22:20:07, gogerald1 wrote:
> have you considered automatically generate enum in C++ side to java side? It
is
> easier to maintain in that way, refer here for reference
>
https://cs.chromium.org/chromium/src/components/signin/core/browser/signin_me...

Wow thanks for the tip, that's pretty cool! Do you mind if I do it in another
CL? I think it will be more clear that way.

https://codereview.chromium.org/2899313002/diff/140001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/JourneyLogger.java:195:
* @param submissionType An int indicating why the payment request was aborted.
On 2017/05/25 22:20:07, gogerald1 wrote:
> @param reason?

Done.

https://codereview.chromium.org/2899313002/diff/140001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/JourneyLogger.java:212:
* @param submissionType An int indicating why the payment request was not shown.
On 2017/05/25 22:20:07, gogerald1 wrote:
> @param reason?

Done.

https://codereview.chromium.org/2899313002/diff/140001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestMetrics.java
(right):

https://codereview.chromium.org/2899313002/diff/140001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestMetrics.java:13:
public final class PaymentRequestMetrics {
On 2017/05/25 22:20:07, gogerald1 wrote:
> Do we have plan to move the rest of the metrics in this file to native side as
> well?

Yep! They are the last 2 that need to move :)

[sebsg, 2017-05-26 13:12:29]

The CQ bit was checked by sebsg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 13:12:40]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 14:09:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 14:09:10]

Dry run: This issue passed the CQ dry run.

[gogerald1, 2017-05-26 14:20:08]

lgtm

https://codereview.chromium.org/2899313002/diff/140001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/JourneyLogger.java
(right):

https://codereview.chromium.org/2899313002/diff/140001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/JourneyLogger.java:57:
public static final int ABORT_REASON_ABORTED_BY_USER = 0;
On 2017/05/26 13:12:22, sebsg wrote:
> On 2017/05/25 22:20:07, gogerald1 wrote:
> > have you considered automatically generate enum in C++ side to java side? It
> is
> > easier to maintain in that way, refer here for reference
> >
>
https://cs.chromium.org/chromium/src/components/signin/core/browser/signin_me...
> 
> Wow thanks for the tip, that's pretty cool! Do you mind if I do it in another
> CL? I think it will be more clear that way.

Acknowledged.

[sebsg, 2017-05-26 14:28:37]

The CQ bit was checked by sebsg@chromium.org

[sebsg, 2017-05-26 14:28:37]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org
Link to the patchset: https://codereview.chromium.org/2899313002/#ps160001
(title: "Addressed comments")

[commit-bot: I haz the power, 2017-05-26 14:28:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 14:33:00]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1495808917086980,
"parent_rev": "99a1d0db25c2b77ad42d216b2289e0bf67c69540", "commit_rev":
"f8272a2043eeddf86177a2c643215d5060066122"}

[commit-bot: I haz the power, 2017-05-26 14:33:12]

Description was changed from

==========
[Payments] Move the logging for checkout flow to native.

BUG=726469
==========

to

==========
[Payments] Move the logging for checkout flow to native.

BUG=726469

Review-Url: https://codereview.chromium.org/2899313002
Cr-Commit-Position: refs/heads/master@{#475001}
Committed:
https://chromium.googlesource.com/chromium/src/+/f8272a2043eeddf86177a2c64321...
==========

[commit-bot: I haz the power, 2017-05-26 14:33:13]

Committed patchset #2 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/f8272a2043eeddf86177a2c64321...