Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1792)

Unified Diff: chrome/browser/payments/android/journey_logger_android.cc

Issue 2899313002: [Payments] Move the logging for checkout flow to native. (Closed)
Patch Set: Addressed comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/payments/android/journey_logger_android.cc
diff --git a/chrome/browser/payments/android/journey_logger_android.cc b/chrome/browser/payments/android/journey_logger_android.cc
index a00270c54ee7983fcccc7345d9aac3d77e6d2156..d06b2db15cde74074a8730d760fff1c88959636d 100644
--- a/chrome/browser/payments/android/journey_logger_android.cc
+++ b/chrome/browser/payments/android/journey_logger_android.cc
@@ -98,15 +98,29 @@ void JourneyLoggerAndroid::SetEventOccurred(
journey_logger_.SetEventOccurred(static_cast<JourneyLogger::Event>(jevent));
}
-void JourneyLoggerAndroid::RecordJourneyStatsHistograms(
+void JourneyLoggerAndroid::SetCompleted(
+ JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& jcaller) {
+ journey_logger_.SetCompleted();
+}
+
+void JourneyLoggerAndroid::SetAborted(
+ JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& jcaller,
+ jint jreason) {
+ DCHECK_GE(jreason, 0);
+ DCHECK_LT(jreason, JourneyLogger::AbortReason::ABORT_REASON_MAX);
+ journey_logger_.SetAborted(static_cast<JourneyLogger::AbortReason>(jreason));
+}
+
+void JourneyLoggerAndroid::SetNotShown(
JNIEnv* env,
const base::android::JavaParamRef<jobject>& jcaller,
- jint jcompletion_status) {
- DCHECK_GE(jcompletion_status, 0);
- DCHECK_LT(jcompletion_status,
- JourneyLogger::CompletionStatus::COMPLETION_STATUS_MAX);
- journey_logger_.RecordJourneyStatsHistograms(
- static_cast<JourneyLogger::CompletionStatus>(jcompletion_status));
+ jint jreason) {
+ DCHECK_GE(jreason, 0);
+ DCHECK_LT(jreason, JourneyLogger::NotShownReason::NOT_SHOWN_REASON_MAX);
+ journey_logger_.SetNotShown(
+ static_cast<JourneyLogger::NotShownReason>(jreason));
}
static jlong InitJourneyLoggerAndroid(
« no previous file with comments | « chrome/browser/payments/android/journey_logger_android.h ('k') | components/payments/content/payment_request.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698