Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 2899173002: Include DDC fixes to dart:html in the main version (Closed)

Created:
3 years, 7 months ago by Alan Knight
Modified:
3 years, 7 months ago
Reviewers:
vsm, terry, Jacob
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : A few more ddc fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -26 lines) Patch
M pkg/dev_compiler/tool/input_sdk/private/foreign_helper.dart View 1 1 chunk +9 lines, -1 line 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/js_helper.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 1 6 chunks +8 lines, -8 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 6 chunks +7 lines, -8 lines 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/idl/dart/dart.idl View 1 1 chunk +9 lines, -0 lines 0 comments Download
M tools/dom/src/EventStreamProvider.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_EventTarget.darttemplate View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLSelectElement.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_SVGElement.darttemplate View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Alan Knight
3 years, 7 months ago (2017-05-23 23:26:08 UTC) #2
Jacob
lgtm
3 years, 7 months ago (2017-05-24 01:11:25 UTC) #3
vsm
lgtm https://codereview.chromium.org/2899173002/diff/1/tools/dom/src/EventStreamProvider.dart File tools/dom/src/EventStreamProvider.dart (right): https://codereview.chromium.org/2899173002/diff/1/tools/dom/src/EventStreamProvider.dart#newcode239 tools/dom/src/EventStreamProvider.dart:239: : _wrapZone<Event, dynamic>((e) => (onData as dynamic)(e)) { ...
3 years, 7 months ago (2017-05-24 13:11:49 UTC) #4
Alan Knight
Committed patchset #2 (id:20001) manually as b4b02daade289729cfffd84bab9dcfe9575876fe (presubmit successful).
3 years, 7 months ago (2017-05-24 19:49:20 UTC) #6
terry
3 years, 7 months ago (2017-05-25 12:21:40 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698