Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: sdk/lib/html/dart2js/html_dart2js.dart

Issue 2899173002: Include DDC fixes to dart:html in the main version (Closed)
Patch Set: A few more ddc fixes Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « pkg/dev_compiler/tool/input_sdk/private/js_helper.dart ('k') | sdk/lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/html/dart2js/html_dart2js.dart
diff --git a/sdk/lib/html/dart2js/html_dart2js.dart b/sdk/lib/html/dart2js/html_dart2js.dart
index 54478be4ce1ea0156dd4c2dec029cea0453539e4..796ae67365a2fcd4b8c2d948c39a1b1ffd9a3e46 100644
--- a/sdk/lib/html/dart2js/html_dart2js.dart
+++ b/sdk/lib/html/dart2js/html_dart2js.dart
@@ -16862,7 +16862,7 @@ class Events {
Events(this._ptr);
- Stream operator [](String type) {
+ Stream<Event> operator [](String type) {
return new _EventStream(_ptr, type, false);
}
}
@@ -16887,7 +16887,7 @@ class ElementEvents extends Events {
ElementEvents(Element ptr) : super(ptr);
- Stream operator [](String type) {
+ Stream<Event> operator [](String type) {
if (webkitEvents.keys.contains(type.toLowerCase())) {
if (Device.isWebKit) {
return new _ElementEventStreamImpl(
@@ -16944,7 +16944,7 @@ class EventTarget extends Interceptor {
@JSName('addEventListener')
@DomName('EventTarget.addEventListener')
@DocsEditable()
- void _addEventListener(String type, EventListener listener, [Object options])
+ void _addEventListener(String type, EventListener listener, [bool options])
native;
@DomName('EventTarget.dispatchEvent')
@@ -16954,8 +16954,8 @@ class EventTarget extends Interceptor {
@JSName('removeEventListener')
@DomName('EventTarget.removeEventListener')
@DocsEditable()
- void _removeEventListener(String type, EventListener listener,
- [Object options]) native;
+ void _removeEventListener(String type, EventListener listener, [bool options])
+ native;
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
@@ -31068,8 +31068,8 @@ class SelectElement extends HtmlElement {
// Override default options, since IE returns SelectElement itself and it
// does not operate as a List.
List<OptionElement> get options {
- var options = new List<OptionElement>.from(this.querySelectorAll('option'));
- return new UnmodifiableListView(options);
+ var options = this.querySelectorAll<OptionElement>('option');
+ return new UnmodifiableListView(options.toList());
}
List<OptionElement> get selectedOptions {
@@ -42988,7 +42988,7 @@ class _EventStreamSubscription<T extends Event> extends StreamSubscription<T> {
this._target, this._eventType, void onData(T event), this._useCapture)
: _onData = onData == null
? null
- : _wrapZone/*<Event, dynamic>*/((e) => (onData as dynamic)(e)) {
+ : _wrapZone<Event, dynamic>((e) => (onData as dynamic)(e)) {
_tryResume();
}
« no previous file with comments | « pkg/dev_compiler/tool/input_sdk/private/js_helper.dart ('k') | sdk/lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698