Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: sdk/lib/html/dartium/html_dartium.dart

Issue 2899173002: Include DDC fixes to dart:html in the main version (Closed)
Patch Set: A few more ddc fixes Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « sdk/lib/html/dart2js/html_dart2js.dart ('k') | sdk/lib/svg/dart2js/svg_dart2js.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/html/dartium/html_dartium.dart
diff --git a/sdk/lib/html/dartium/html_dartium.dart b/sdk/lib/html/dartium/html_dartium.dart
index 257bfae68caaa9778c86426570b6461d56862cef..cd425135f3c51adb8a621a4d06879eb514005b7e 100644
--- a/sdk/lib/html/dartium/html_dartium.dart
+++ b/sdk/lib/html/dartium/html_dartium.dart
@@ -17859,7 +17859,7 @@ class Events {
Events(this._ptr);
- Stream operator [](String type) {
+ Stream<Event> operator [](String type) {
return new _EventStream(_ptr, type, false);
}
}
@@ -17884,7 +17884,7 @@ class ElementEvents extends Events {
ElementEvents(Element ptr) : super(ptr);
- Stream operator [](String type) {
+ Stream<Event> operator [](String type) {
if (webkitEvents.keys.contains(type.toLowerCase())) {
if (Device.isWebKit) {
return new _ElementEventStreamImpl(
@@ -17949,8 +17949,7 @@ class EventTarget extends DartHtmlDomObject {
@DomName('EventTarget.addEventListener')
@DocsEditable()
- void _addEventListener(String type, EventListener listener,
- [Object options]) =>
+ void _addEventListener(String type, EventListener listener, [bool options]) =>
_blink.BlinkEventTarget.instance
.addEventListener_Callback_3_(this, type, listener, options);
@@ -17962,7 +17961,7 @@ class EventTarget extends DartHtmlDomObject {
@DomName('EventTarget.removeEventListener')
@DocsEditable()
void _removeEventListener(String type, EventListener listener,
- [Object options]) =>
+ [bool options]) =>
_blink.BlinkEventTarget.instance
.removeEventListener_Callback_3_(this, type, listener, options);
}
@@ -35792,8 +35791,8 @@ class SelectElement extends HtmlElement {
// Override default options, since IE returns SelectElement itself and it
// does not operate as a List.
List<OptionElement> get options {
- var options = new List<OptionElement>.from(this.querySelectorAll('option'));
- return new UnmodifiableListView(options);
+ var options = this.querySelectorAll<OptionElement>('option');
+ return new UnmodifiableListView(options.toList());
}
List<OptionElement> get selectedOptions {
@@ -49143,7 +49142,7 @@ class _EventStreamSubscription<T extends Event> extends StreamSubscription<T> {
this._target, this._eventType, void onData(T event), this._useCapture)
: _onData = onData == null
? null
- : _wrapZone/*<Event, dynamic>*/((e) => (onData as dynamic)(e)) {
+ : _wrapZone<Event, dynamic>((e) => (onData as dynamic)(e)) {
_tryResume();
}
« no previous file with comments | « sdk/lib/html/dart2js/html_dart2js.dart ('k') | sdk/lib/svg/dart2js/svg_dart2js.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698