Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2899103002: Revert of Disable flaky WebRtcInternalsPerfBrowserTest on Windows. (Closed)

Created:
3 years, 7 months ago by emircan
Modified:
3 years, 7 months ago
Reviewers:
Max Morin
CC:
chromium-reviews, chfremer+watch_chromium.org, phoglund+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable flaky WebRtcInternalsPerfBrowserTest on Windows. (patchset #2 id:20001 of https://codereview.chromium.org/2842643003/ ) Reason for revert: This test should pass after the fixes on issue webrtc:7532. See the explanation https://bugs.chromium.org/p/chromium/issues/detail?id=722746#c21 for how they are related. Original issue's description: > Disable flaky WebRtcInternalsPerfBrowserTest on Windows. > > WebRtcInternalsPerfBrowserTest.MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsH264 > is flaky on Windows. > > BUG=703579 > TBR=hbos@chromium.org > > Review-Url: https://codereview.chromium.org/2842643003 > Cr-Commit-Position: refs/heads/master@{#466964} > Committed: https://chromium.googlesource.com/chromium/src/+/774479d06817e48e69fdce1d464cc2299c81e01d TBR=maxmorin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=703579 Review-Url: https://codereview.chromium.org/2899103002 Cr-Commit-Position: refs/heads/master@{#474054} Committed: https://chromium.googlesource.com/chromium/src/+/778f69d41ab8539ec7d45d7e24ed58582133d00e

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M chrome/browser/media/webrtc/webrtc_internals_perf_browsertest.cc View 1 1 chunk +1 line, -9 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
emircan
Created Revert of Disable flaky WebRtcInternalsPerfBrowserTest on Windows.
3 years, 7 months ago (2017-05-23 20:07:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2899103002/1
3 years, 7 months ago (2017-05-23 20:09:04 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xcode-clang/builds/105920) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 7 months ago (2017-05-23 20:12:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2899103002/40001
3 years, 7 months ago (2017-05-23 21:09:30 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 21:14:31 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/778f69d41ab8539ec7d45d7e24ed...

Powered by Google App Engine
This is Rietveld 408576698