Delete unused tutorial code from profile switcher/user manager.

It appears the tutorial mode is never set, and even if it were set the
code that creates tutorial UI is never referenced anywhere.

Review-Url: https://codereview.chromium.org/2899083003
Cr-Commit-Position: refs/heads/master@{#475755}
Committed: https://chromium.googlesource.com/chromium/src/+/35ec955d7d925e1daa08b0944790cc689016add9

[Bret, 2017-05-24 02:24:11]

The CQ bit was checked by bsep@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 02:25:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 02:40:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 02:40:44]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Bret, 2017-05-24 19:08:16]

The CQ bit was checked by bsep@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 19:09:00]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 19:26:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 19:26:27]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Bret, 2017-05-24 20:58:14]

The CQ bit was checked by bsep@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 20:58:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bret, 2017-05-24 21:01:46]

Description was changed from

==========
TODO

BUG=
==========

to

==========
It appears the tutorial mode is never set, and even if it were set the
code that creates tutorial UI is never referenced anywhere.
==========

[commit-bot: I haz the power, 2017-05-24 21:15:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 21:15:51]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Bret, 2017-05-24 22:02:20]

The CQ bit was checked by bsep@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 22:03:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 22:19:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 22:19:16]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Bret, 2017-05-24 22:26:14]

The CQ bit was checked by bsep@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 22:27:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 22:56:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 22:56:59]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Bret, 2017-05-24 23:23:45]

The CQ bit was checked by bsep@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 23:24:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bret, 2017-05-25 00:27:53]

bsep@chromium.org changed reviewers:
+ ellyjones@chromium.org, sky@chromium.org

[Bret, 2017-05-25 00:27:54]

ellyjones@: cocoa changes
sky@: views changes

I'll do specific OWNERS after

[Bret, 2017-05-25 00:40:48]

The CQ bit was checked by bsep@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 00:41:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 02:33:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 02:33:44]

Dry run: This issue passed the CQ dry run.

[sky, 2017-05-25 02:54:49]

Can you also add the person that adds this code to make sure it should be
removed.

On Wed, May 24, 2017 at 5:27 PM, <bsep@chromium.org> wrote:

> Reviewers: Elly Fong-Jones, sky
> CL: https://codereview.chromium.org/2899083003/
>
> Message:
> ellyjones@: cocoa changes
> sky@: views changes
>
> I'll do specific OWNERS after
>
> Description:
> It appears the tutorial mode is never set, and even if it were set the
> code that creates tutorial UI is never referenced anywhere.
>
> Affected files (+24, -762 lines):
> M chrome/browser/app_controller_mac.mm
> M chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc
> M chrome/browser/background/background_mode_manager.cc
> M chrome/browser/profiles/avatar_menu.cc
> M chrome/browser/profiles/profile_window.h
> M chrome/browser/profiles/profile_window.cc
> M chrome/browser/profiles/profile_window_browsertest.cc
> M chrome/browser/signin/chrome_signin_client.cc
> M chrome/browser/ui/app_list/app_list_service_disabled.cc
> M chrome/browser/ui/app_list/profile_loader.cc
> M chrome/browser/ui/cocoa/browser_window_cocoa.mm
> M chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm
> M chrome/browser/ui/cocoa/profiles/profile_chooser_controller.h
> M chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
> M chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm
> M chrome/browser/ui/cocoa/profiles/user_manager_mac.mm
> M chrome/browser/ui/cocoa/profiles/user_manager_mac_unittest.mm
> M chrome/browser/ui/extensions/extension_enable_flow.cc
> M chrome/browser/ui/profile_chooser_constants.h
> M chrome/browser/ui/startup/startup_browser_creator.cc
> M chrome/browser/ui/user_manager.h
> M chrome/browser/ui/views/frame/browser_view.cc
> M chrome/browser/ui/views/profiles/profile_chooser_view.h
> M chrome/browser/ui/views/profiles/profile_chooser_view.cc
> M chrome/browser/ui/views/profiles/user_manager_view.cc
> M chrome/browser/ui/webui/profile_helper.cc
> M chrome/browser/ui/webui/settings/people_handler.cc
>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Elly Fong-Jones, 2017-05-25 12:49:36]

It looks like it was added in https://codereview.chromium.org/1120013003 on
2015-05-19 and then the feature it was a tutorial for was removed in
https://codereview.chromium.org/2709763002 on 2017-03-22 and the tutorial was
meant to be removed (but wasn't completely removed) in
https://codereview.chromium.org/2765413002 on 2017-03-28.

On 2017/05/25 02:54:49, sky wrote:
> Can you also add the person that adds this code to make sure it should be
> removed.
> 
> On Wed, May 24, 2017 at 5:27 PM, <mailto:bsep@chromium.org> wrote:
> 
> > Reviewers: Elly Fong-Jones, sky
> > CL: https://codereview.chromium.org/2899083003/
> >
> > Message:
> > ellyjones@: cocoa changes
> > sky@: views changes
> >
> > I'll do specific OWNERS after
> >
> > Description:
> > It appears the tutorial mode is never set, and even if it were set the
> > code that creates tutorial UI is never referenced anywhere.
> >
> > Affected files (+24, -762 lines):
> > M chrome/browser/app_controller_mac.mm
> > M chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc
> > M chrome/browser/background/background_mode_manager.cc
> > M chrome/browser/profiles/avatar_menu.cc
> > M chrome/browser/profiles/profile_window.h
> > M chrome/browser/profiles/profile_window.cc
> > M chrome/browser/profiles/profile_window_browsertest.cc
> > M chrome/browser/signin/chrome_signin_client.cc
> > M chrome/browser/ui/app_list/app_list_service_disabled.cc
> > M chrome/browser/ui/app_list/profile_loader.cc
> > M chrome/browser/ui/cocoa/browser_window_cocoa.mm
> > M chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm
> > M chrome/browser/ui/cocoa/profiles/profile_chooser_controller.h
> > M chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
> > M chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm
> > M chrome/browser/ui/cocoa/profiles/user_manager_mac.mm
> > M chrome/browser/ui/cocoa/profiles/user_manager_mac_unittest.mm
> > M chrome/browser/ui/extensions/extension_enable_flow.cc
> > M chrome/browser/ui/profile_chooser_constants.h
> > M chrome/browser/ui/startup/startup_browser_creator.cc
> > M chrome/browser/ui/user_manager.h
> > M chrome/browser/ui/views/frame/browser_view.cc
> > M chrome/browser/ui/views/profiles/profile_chooser_view.h
> > M chrome/browser/ui/views/profiles/profile_chooser_view.cc
> > M chrome/browser/ui/views/profiles/user_manager_view.cc
> > M chrome/browser/ui/webui/profile_helper.cc
> > M chrome/browser/ui/webui/settings/people_handler.cc
> >
> >
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[Elly Fong-Jones, 2017-05-25 12:53:29]

chrome/browser/ui/cocoa lgtm

[sky, 2017-05-25 17:37:14]

sky@chromium.org changed reviewers:
+ anthonyvd@chromium.org

[sky, 2017-05-25 17:37:15]

+anthonyvd

[anthonyvd, 2017-05-25 17:41:24]

Awesome cleanup, lgtm

+CC a couple of people involved in the User Manager as FYI

[Bret, 2017-05-25 19:09:16]

bsep@chromium.org changed reviewers:
+ dominickn@chromium.org, rogerta@chromium.org, thakis@chromium.org

[Bret, 2017-05-25 19:14:14]

Okay, just need some quick OWNERS approvals, all tiny changes:
thakis@: c/b/app_controller_mac.mm
dominickn@: c/b/apps/app_shim/extension_app_shim_handler_mac.cc
rogerta@: c/b/signin/chrome_signin_client.cc

And need sky@ for c/b/ui

Thanks for the reviews everyone!

[Nico, 2017-05-25 19:14:55]

chrome/browser/app_controller_mac.mm lgtm

[sky, 2017-05-25 19:32:07]

One question.

https://codereview.chromium.org/2899083003/diff/110001/chrome/browser/ui/view...
File chrome/browser/ui/views/profiles/profile_chooser_view.cc (left):

https://codereview.chromium.org/2899083003/diff/110001/chrome/browser/ui/view...
chrome/browser/ui/views/profiles/profile_chooser_view.cc:508: if (tutorial_mode
!= profiles::TUTORIAL_MODE_NONE) {
Previously wouldn't tutorial_mode always be MODE_NONE? In which case this branch
is hit and ShowViewFromMode was called?

[Bret, 2017-05-25 20:32:25]

https://codereview.chromium.org/2899083003/diff/110001/chrome/browser/ui/view...
File chrome/browser/ui/views/profiles/profile_chooser_view.cc (left):

https://codereview.chromium.org/2899083003/diff/110001/chrome/browser/ui/view...
chrome/browser/ui/views/profiles/profile_chooser_view.cc:508: if (tutorial_mode
!= profiles::TUTORIAL_MODE_NONE) {
On 2017/05/25 19:32:07, sky wrote:
> Previously wouldn't tutorial_mode always be MODE_NONE? In which case this
branch
> is hit and ShowViewFromMode was called?

Hmm, I think you have the logic here backwards. I guess tutorial_mode was
occasionally not MODE_NONE, when the view_mode was PROFILE_SWITCHER so this
branch may have actually been hit... but I tested the button that invokes this
method and it seems to still work. So I think I'll leave it as is.

[sky, 2017-05-25 22:56:13]

LGTM

https://codereview.chromium.org/2899083003/diff/110001/chrome/browser/ui/view...
File chrome/browser/ui/views/profiles/profile_chooser_view.cc (left):

https://codereview.chromium.org/2899083003/diff/110001/chrome/browser/ui/view...
chrome/browser/ui/views/profiles/profile_chooser_view.cc:508: if (tutorial_mode
!= profiles::TUTORIAL_MODE_NONE) {
On 2017/05/25 20:32:25, Bret Sepulveda wrote:
> On 2017/05/25 19:32:07, sky wrote:
> > Previously wouldn't tutorial_mode always be MODE_NONE? In which case this
> branch
> > is hit and ShowViewFromMode was called?
> 
> Hmm, I think you have the logic here backwards. I guess tutorial_mode was
> occasionally not MODE_NONE, when the view_mode was PROFILE_SWITCHER so this
> branch may have actually been hit... but I tested the button that invokes this
> method and it seems to still work. So I think I'll leave it as is.

D'OH! You are correct, I read it wrong.

[dominickn, 2017-05-26 00:06:03]

extension_app_shim_handler lgtm

[Roger Tawa OOO till Jul 10th, 2017-05-30 18:45:14]

chrome/browser/signin/chrome_signin_client.cc lgtm

[Bret, 2017-05-30 18:45:43]

The CQ bit was checked by bsep@chromium.org

[commit-bot: I haz the power, 2017-05-30 18:46:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 18:50:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 18:50:12]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Bret, 2017-05-31 01:17:26]

The CQ bit was checked by bsep@chromium.org

[Bret, 2017-05-31 01:17:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
dominickn@chromium.org, rogerta@chromium.org, sky@chromium.org,
anthonyvd@chromium.org, ellyjones@chromium.org, thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2899083003/#ps130001
(title: "fix merge")

[commit-bot: I haz the power, 2017-05-31 01:18:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 02:47:07]

CQ is committing da patch.

Bot data: {"patchset_id": 130001, "attempt_start_ts": 1496193446791760,
"parent_rev": "7135e898f08758f2968c75dde6a16aa428a48084", "commit_rev":
"35ec955d7d925e1daa08b0944790cc689016add9"}

[commit-bot: I haz the power, 2017-05-31 02:47:19]

Description was changed from

==========
It appears the tutorial mode is never set, and even if it were set the
code that creates tutorial UI is never referenced anywhere.
==========

to

==========
It appears the tutorial mode is never set, and even if it were set the
code that creates tutorial UI is never referenced anywhere.

Review-Url: https://codereview.chromium.org/2899083003
Cr-Commit-Position: refs/heads/master@{#475755}
Committed:
https://chromium.googlesource.com/chromium/src/+/35ec955d7d925e1daa08b0944790...
==========

[commit-bot: I haz the power, 2017-05-31 02:47:21]

Committed patchset #8 (id:130001) as
https://chromium.googlesource.com/chromium/src/+/35ec955d7d925e1daa08b0944790...