Removing Fast User Switcher feature.

Removing Fast User Switcher feature.

Fast User Switcher is not supported anymore.

BUG=694285
Review-Url: https://codereview.chromium.org/2709763002
Cr-Commit-Position: refs/heads/master@{#458828}
Committed: https://chromium.googlesource.com/chromium/src/+/39480fd2b6d3b9a01026520f6bc50c42f23850b0

[jlebel, 2017-02-21 14:20:53]

Patchset #1 (id:1) has been deleted

[jlebel, 2017-02-21 14:22:47]

jlebel@chromium.org changed reviewers:
+ sky@chromium.org

[jlebel, 2017-02-21 14:22:48]

Hello sky,

As we talk about it on crrev.com/2687693002, I'm removing Fast User Switcher
feature.
Can you review this patch?

Thanks,

[jlebel, 2017-02-21 14:27:09]

The CQ bit was checked by jlebel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 14:27:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 15:23:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 15:23:04]

Dry run: This issue passed the CQ dry run.

[sky, 2017-02-21 18:30:25]

https://codereview.chromium.org/2709763002/diff/20001/chrome/app/chrome_comma...
File chrome/app/chrome_command_ids.h (right):

https://codereview.chromium.org/2709763002/diff/20001/chrome/app/chrome_comma...
chrome/app/chrome_command_ids.h:176: #define IDC_TOGGLE_FULLSCREEN_TOOLBAR  
40251
Change to 40250?

https://codereview.chromium.org/2709763002/diff/20001/chrome/browser/ui/brows...
File chrome/browser/ui/browser_commands.cc (left):

https://codereview.chromium.org/2709763002/diff/20001/chrome/browser/ui/brows...
chrome/browser/ui/browser_commands.cc:1133:
BrowserWindow::AVATAR_BUBBLE_MODE_FAST_USER_SWITCH,
Can this enum value be removed?

https://codereview.chromium.org/2709763002/diff/20001/chrome/browser/ui/brows...
chrome/browser/ui/browser_commands.cc:1135:
signin_metrics::AccessPoint::ACCESS_POINT_AVATAR_BUBBLE_SIGN_IN);
And this one too?

[jlebel, 2017-02-21 21:57:21]

On 2017/02/21 18:30:25, sky wrote:
>
https://codereview.chromium.org/2709763002/diff/20001/chrome/app/chrome_comma...
> File chrome/app/chrome_command_ids.h (right):
> 
>
https://codereview.chromium.org/2709763002/diff/20001/chrome/app/chrome_comma...
> chrome/app/chrome_command_ids.h:176: #define IDC_TOGGLE_FULLSCREEN_TOOLBAR  
> 40251
> Change to 40250?
> 
>
https://codereview.chromium.org/2709763002/diff/20001/chrome/browser/ui/brows...
> File chrome/browser/ui/browser_commands.cc (left):
> 
>
https://codereview.chromium.org/2709763002/diff/20001/chrome/browser/ui/brows...
> chrome/browser/ui/browser_commands.cc:1133:
> BrowserWindow::AVATAR_BUBBLE_MODE_FAST_USER_SWITCH,
> Can this enum value be removed?
> 
>
https://codereview.chromium.org/2709763002/diff/20001/chrome/browser/ui/brows...
> chrome/browser/ui/browser_commands.cc:1135:
> signin_metrics::AccessPoint::ACCESS_POINT_AVATAR_BUBBLE_SIGN_IN);
> And this one too?

@anthonyvd told me I should remove other dead code first (related to none
material design profile switcher menu).
I will redo a new patch about FastUserSwitcher once I will be done with this
other task.
I'm keeping this patch to make sure I will not miss your comments.

[sky, 2017-02-22 00:26:56]

Ok, ping this review when you want me to look again.

On Tue, Feb 21, 2017 at 1:57 PM,  <jlebel@chromium.org> wrote:
> On 2017/02/21 18:30:25, sky wrote:
>>
>
https://codereview.chromium.org/2709763002/diff/20001/chrome/app/chrome_comma...
>> File chrome/app/chrome_command_ids.h (right):
>>
>>
>
https://codereview.chromium.org/2709763002/diff/20001/chrome/app/chrome_comma...
>> chrome/app/chrome_command_ids.h:176: #define IDC_TOGGLE_FULLSCREEN_TOOLBAR
>> 40251
>> Change to 40250?
>>
>>
>
https://codereview.chromium.org/2709763002/diff/20001/chrome/browser/ui/brows...
>> File chrome/browser/ui/browser_commands.cc (left):
>>
>>
>
https://codereview.chromium.org/2709763002/diff/20001/chrome/browser/ui/brows...
>> chrome/browser/ui/browser_commands.cc:1133:
>> BrowserWindow::AVATAR_BUBBLE_MODE_FAST_USER_SWITCH,
>> Can this enum value be removed?
>>
>>
>
https://codereview.chromium.org/2709763002/diff/20001/chrome/browser/ui/brows...
>> chrome/browser/ui/browser_commands.cc:1135:
>> signin_metrics::AccessPoint::ACCESS_POINT_AVATAR_BUBBLE_SIGN_IN);
>> And this one too?
>
> @anthonyvd told me I should remove other dead code first (related to none
> material design profile switcher menu).
> I will redo a new patch about FastUserSwitcher once I will be done with this
> other task.
> I'm keeping this patch to make sure I will not miss your comments.
>
> https://codereview.chromium.org/2709763002/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[jlebel, 2017-03-21 18:35:56]

Patchset #2 (id:40001) has been deleted

[jlebel, 2017-03-21 18:39:06]

Patchset #2 (id:60001) has been deleted

[jlebel, 2017-03-22 15:09:01]

Patchset #2 (id:80001) has been deleted

[jlebel, 2017-03-22 16:04:08]

Hello Scott,

I've updated this patch. You can review it when you will have time.

There is some more code that need to be removed (related to
kProfileAvatarRightClickTutorialDismissed), but I will do it in another patch if
you don't mind. I've updated the bug so I won't forget.

Thanks,

https://codereview.chromium.org/2709763002/diff/20001/chrome/app/chrome_comma...
File chrome/app/chrome_command_ids.h (right):

https://codereview.chromium.org/2709763002/diff/20001/chrome/app/chrome_comma...
chrome/app/chrome_command_ids.h:176: #define IDC_TOGGLE_FULLSCREEN_TOOLBAR  
40251
On 2017/02/21 18:30:25, sky wrote:
> Change to 40250?

Done.

https://codereview.chromium.org/2709763002/diff/20001/chrome/browser/ui/brows...
File chrome/browser/ui/browser_commands.cc (left):

https://codereview.chromium.org/2709763002/diff/20001/chrome/browser/ui/brows...
chrome/browser/ui/browser_commands.cc:1133:
BrowserWindow::AVATAR_BUBBLE_MODE_FAST_USER_SWITCH,
On 2017/02/21 18:30:25, sky wrote:
> Can this enum value be removed?

Done.

https://codereview.chromium.org/2709763002/diff/20001/chrome/browser/ui/brows...
chrome/browser/ui/browser_commands.cc:1135:
signin_metrics::AccessPoint::ACCESS_POINT_AVATAR_BUBBLE_SIGN_IN);
On 2017/02/21 18:30:25, sky wrote:
> And this one too?

No, this value is used just above (when using open the profile menu, the regular
way).

[sky, 2017-03-22 16:57:34]

https://codereview.chromium.org/2709763002/diff/100001/chrome/browser/ui/brow...
File chrome/browser/ui/browser_commands.cc (left):

https://codereview.chromium.org/2709763002/diff/100001/chrome/browser/ui/brow...
chrome/browser/ui/browser_commands.cc:1136:
signin_metrics::AccessPoint::ACCESS_POINT_AVATAR_BUBBLE_SIGN_IN, false);
Is ACCESS_POINT_AVATAR_BUBBLE_SIGN_IN used anymore?

https://codereview.chromium.org/2709763002/diff/100001/chrome/browser/ui/view...
File chrome/browser/ui/views/profiles/profile_chooser_view.cc (right):

https://codereview.chromium.org/2709763002/diff/100001/chrome/browser/ui/view...
chrome/browser/ui/views/profiles/profile_chooser_view.cc:1086:
PopulateCompleteProfileChooserView(layout, avatar_menu);
As PopulateCompleteProfileChooserView is only called from here does it make
sense to move the implementation of PopulateCompleteProfileChooserView here and
remove PopulateCompleteProfileChooserView?

[jlebel, 2017-03-22 17:28:14]

Thanks,

https://codereview.chromium.org/2709763002/diff/100001/chrome/browser/ui/brow...
File chrome/browser/ui/browser_commands.cc (left):

https://codereview.chromium.org/2709763002/diff/100001/chrome/browser/ui/brow...
chrome/browser/ui/browser_commands.cc:1136:
signin_metrics::AccessPoint::ACCESS_POINT_AVATAR_BUBBLE_SIGN_IN, false);
On 2017/03/22 16:57:34, sky wrote:
> Is ACCESS_POINT_AVATAR_BUBBLE_SIGN_IN used anymore?

No, this value is used just above (when using open the profile menu, the regular
way).

https://codereview.chromium.org/2709763002/diff/100001/chrome/browser/ui/view...
File chrome/browser/ui/views/profiles/profile_chooser_view.cc (right):

https://codereview.chromium.org/2709763002/diff/100001/chrome/browser/ui/view...
chrome/browser/ui/views/profiles/profile_chooser_view.cc:1086:
PopulateCompleteProfileChooserView(layout, avatar_menu);
On 2017/03/22 16:57:34, sky wrote:
> As PopulateCompleteProfileChooserView is only called from here does it make
> sense to move the implementation of PopulateCompleteProfileChooserView here
and
> remove PopulateCompleteProfileChooserView?

Done.
Also, I forgot to remove
ProfileChooserView::PopulateMinimalProfileChooserView().

[sky, 2017-03-22 17:46:47]

LGTM

[jlebel, 2017-03-22 17:48:04]

The CQ bit was checked by jlebel@chromium.org

[commit-bot: I haz the power, 2017-03-22 17:48:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 19:13:12]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1490204884162930,
"parent_rev": "2d30e002c7613a18fed1c12da55a4a5527dd36aa", "commit_rev":
"39480fd2b6d3b9a01026520f6bc50c42f23850b0"}

[commit-bot: I haz the power, 2017-03-22 19:14:06]

Description was changed from

==========
Removing Fast User Switcher feature.

Fast User Switcher is not supported anymore.

BUG=694285
==========

to

==========
Removing Fast User Switcher feature.

Fast User Switcher is not supported anymore.

BUG=694285

Review-Url: https://codereview.chromium.org/2709763002
Cr-Commit-Position: refs/heads/master@{#458828}
Committed:
https://chromium.googlesource.com/chromium/src/+/39480fd2b6d3b9a01026520f6bc5...
==========

[commit-bot: I haz the power, 2017-03-22 19:14:07]

Committed patchset #3 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/39480fd2b6d3b9a01026520f6bc5...