Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2898953006:
Mac: Disable r470769. I.e., Don't pump chrome tasks in private message loop modes. (Closed)
DescriptionMac: Disable r470769. I.e., Don't pump chrome tasks in private message loop modes.
It interacts badly with NSMenus on the native print dialog.
To fix, we may need to use a scoping class that adds these modes only
for menus that Chrome runs. Defer that to m61.
BUG=726200, 602914, 640466
TEST=Click the "Print using system dialog..." link in Print Preview,
then select "Save as PDF" via the [PDF] button in the native print
dialog. Chrome shouldn't hang.
Review-Url: https://codereview.chromium.org/2898953006
Cr-Commit-Position: refs/heads/master@{#474621}
Committed: https://chromium.googlesource.com/chromium/src/+/08c4e3028cf0a15630a07874da6eec8694682ce4
Patch Set 1 #
Messages
Total messages: 20 (11 generated)
The CQ bit was checked by tapted@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Mac: Disable r470769. I.e., Don't pump chrome tasks in private message loop modes. It interacts badly with NSMenus on the native print dialog. To fix, we may need to use a scoping class that adds these modes only for menus that Chrome runs. BUG=726200, 602914, 640466 TEST=Click the "Print using system dialog..." link in Print Preview, then select "Save as PDF" via the [PDF] button in the native print dialog. Chrome shouldn't hang. ========== to ========== Mac: Disable r470769. I.e., Don't pump chrome tasks in private message loop modes. It interacts badly with NSMenus on the native print dialog. To fix, we may need to use a scoping class that adds these modes only for menus that Chrome runs. Defer that to m61. BUG=726200, 602914, 640466 TEST=Click the "Print using system dialog..." link in Print Preview, then select "Save as PDF" via the [PDF] button in the native print dialog. Chrome shouldn't hang. ==========
tapted@chromium.org changed reviewers: + avi@chromium.org
lgtm
The CQ bit was unchecked by tapted@chromium.org
Thanks for catching this avi! Confirmed locally this fixes the system print dialog. (And the other things wanting this are robust about not having these modes run - they just aren't as sleek).
The CQ bit was checked by tapted@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
tapted@chromium.org changed reviewers: + mark@chromium.org
+mark for base/OWNERS - ptal (dang it, I briefly thought this was in ui/base..)
LGTM
The CQ bit was checked by tapted@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1495708786440180, "parent_rev":
"f19630697d1279c5b9a70fb250060dbadff1dbc8", "commit_rev":
"08c4e3028cf0a15630a07874da6eec8694682ce4"}
Message was sent while issue was closed.
Description was changed from ========== Mac: Disable r470769. I.e., Don't pump chrome tasks in private message loop modes. It interacts badly with NSMenus on the native print dialog. To fix, we may need to use a scoping class that adds these modes only for menus that Chrome runs. Defer that to m61. BUG=726200, 602914, 640466 TEST=Click the "Print using system dialog..." link in Print Preview, then select "Save as PDF" via the [PDF] button in the native print dialog. Chrome shouldn't hang. ========== to ========== Mac: Disable r470769. I.e., Don't pump chrome tasks in private message loop modes. It interacts badly with NSMenus on the native print dialog. To fix, we may need to use a scoping class that adds these modes only for menus that Chrome runs. Defer that to m61. BUG=726200, 602914, 640466 TEST=Click the "Print using system dialog..." link in Print Preview, then select "Save as PDF" via the [PDF] button in the native print dialog. Chrome shouldn't hang. Review-Url: https://codereview.chromium.org/2898953006 Cr-Commit-Position: refs/heads/master@{#474621} Committed: https://chromium.googlesource.com/chromium/src/+/08c4e3028cf0a15630a07874da6e... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/08c4e3028cf0a15630a07874da6e... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
