Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5186)

Unified Diff: base/message_loop/message_pump_mac.mm

Issue 2898953006: Mac: Disable r470769. I.e., Don't pump chrome tasks in private message loop modes. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/message_loop/message_pump_mac.mm
diff --git a/base/message_loop/message_pump_mac.mm b/base/message_loop/message_pump_mac.mm
index 305234b8170a610682ac271181471c72ee5e89ef..71cb00b80a11356df539e9d3fe101549b042e13f 100644
--- a/base/message_loop/message_pump_mac.mm
+++ b/base/message_loop/message_pump_mac.mm
@@ -47,6 +47,11 @@ const CFStringRef kAllModes[] = {
// Mask that determines which modes in |kAllModes| to use.
enum { kCommonModeMask = 0x1, kAllModesMask = ~0 };
+// Modes to use for MessagePumpNSApplication. Currently just common and
+// exclusive modes. TODO(tapted): Use kAllModesMask once http://crbug.com/640466
+// blockers are fixed.
+enum { kNSApplicationModeMask = 0x3 };
+
void NoOp(void* info) {
}
@@ -722,7 +727,7 @@ void MessagePumpUIApplication::Attach(Delegate* delegate) {
#else
MessagePumpNSApplication::MessagePumpNSApplication()
- : MessagePumpCFRunLoopBase(kAllModesMask),
+ : MessagePumpCFRunLoopBase(kNSApplicationModeMask),
keep_running_(true),
running_own_loop_(false) {}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698